First step to add Mac OS Support #274
Draft
+23
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Converted to draft, please mark as ready for review when you're done. Thank you for your work on getting WinBoat to work under MacOS! |
Hi-Angel
suggested changes
Nov 20, 2025
| const userGroups = (await execAsync('id -Gn')).stdout; | ||
| specs.dockerIsInUserGroups = userGroups.split(/\s+/).includes('docker'); | ||
| if (os.platform() === 'darwin') { | ||
| specs.dockerIsInUserGroups = true; |
There was a problem hiding this comment.
Is that guaranteed on Mac? And I think it warrants a comment.
| try { | ||
| if (os.platform() === 'darwin') { | ||
| specs.kvmEnabled = true; | ||
| } |
There was a problem hiding this comment.
I don't think it's correct. Looking at this post, access to /dev/kvm may or may not exist depending on user configuration, so the check for file existence a few lines below is necessary. You can't just assume the file is accessible on 'darwin'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.