Repository navigation
Bump singer-sdk to 0.54.9 and drop Python 3.10 - #23
Merged
Merged
Conversation
tobiascadee
marked this pull request as ready for review
October 28, 2026 10:18
The development-dependencies bump took pytest to 9.1.1, which warns that class-scoped fixtures defined as instance methods are deprecated. singer-sdk 0.53's get_tap_test_class defines its `runner` fixture that way, and with filterwarnings=error every SDK test errors at setup. singer-sdk 0.54 makes it a classmethod; the ~=0.53.5 pin kept Dependabot from offering that. 0.54 also: - deprecates BaseOffsetPaginator in favour of OffsetPaginator (same constructor and get_next), so the paginator subclasses the new name - warns on Python 3.10, which reached end of life in October 2026, so 3.10 leaves requires-python, the classifiers (and with them the CI matrix) and the tox env list uv.lock is regenerated with uv 0.13 to keep lockfile revision 5. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tobiascadee
force-pushed
the
tobias/singer-sdk-0.54
branch
from
October 28, 2026 10:20
0c836e9 to
86a41bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
teston main is red since the Dependabot development-dependencies bump (#9) took pytest from 9.0.2 to 9.1.1. pytest 9.1 warnsPytestRemovedIn10Warning: Class-scoped fixture defined as instance method is deprecated, and singer-sdk 0.53'sget_tap_test_classdefines itsrunnerfixture exactly that way. Withfilterwarnings = ["error"], 26 of 27 tests error at setup.singer-sdk 0.54 makes
runnera@classmethod. Oursinger-sdk~=0.53.5pin is why Dependabot never offered it.What
singer-sdk~=0.54.9BaseOffsetPaginator→OffsetPaginator: 0.54 deprecates the old name; the constructor andget_nextare unchangedrequires-python >=3.11, classifiers, tox env): 3.10 reached end of life in October 2026, and SDK 0.54 warns about it on every tap init, which also fails underfilterwarnings = ["error"]. The CI matrix is built from the classifiers, so the 3.10 leg goes too.uv.lockregenerated with uv 0.13, keeping lockfile revision 5Locally: ruff 0.17.3, mypy, ty and
uv lock --lockedpass; 27/27 tests pass on 3.11 and 3.14 against the demo key.The other taps on singer-sdk 0.53 with
filterwarnings = ["error"]will hit the same failure once Dependabot bumps pytest to 9.1.🤖 Generated with Claude Code