Skip to content

Bump singer-sdk to 0.54.9 and drop Python 3.10 - #23

Merged
tobiascadee merged 1 commit into
mainfrom
tobias/singer-sdk-0.54
Oct 28, 2026
Merged

tobiascadee merged 1 commit into
mainfrom
tobias/singer-sdk-0.54

Conversation

@tobiascadee

Copy link
Copy Markdown
Collaborator

Why

test on main is red since the Dependabot development-dependencies bump (#9) took pytest from 9.0.2 to 9.1.1. pytest 9.1 warns PytestRemovedIn10Warning: Class-scoped fixture defined as instance method is deprecated, and singer-sdk 0.53's get_tap_test_class defines its runner fixture exactly that way. With filterwarnings = ["error"], 26 of 27 tests error at setup.

singer-sdk 0.54 makes runner a @classmethod. Our singer-sdk~=0.53.5 pin is why Dependabot never offered it.

What

  • singer-sdk~=0.54.9
  • BaseOffsetPaginator → OffsetPaginator: 0.54 deprecates the old name; the constructor and get_next are unchanged
  • drop Python 3.10 (requires-python >=3.11, classifiers, tox env): 3.10 reached end of life in October 2026, and SDK 0.54 warns about it on every tap init, which also fails under filterwarnings = ["error"]. The CI matrix is built from the classifiers, so the 3.10 leg goes too.
  • uv.lock regenerated with uv 0.13, keeping lockfile revision 5

Locally: ruff 0.17.3, mypy, ty and uv lock --locked pass; 27/27 tests pass on 3.11 and 3.14 against the demo key.

The other taps on singer-sdk 0.53 with filterwarnings = ["error"] will hit the same failure once Dependabot bumps pytest to 9.1.

🤖 Generated with Claude Code

@tobiascadee
tobiascadee marked this pull request as ready for review October 28, 2026 10:18
@tobiascadee
tobiascadee requested a review from a team as a code owner October 28, 2026 10:18
The development-dependencies bump took pytest to 9.1.1, which warns
that class-scoped fixtures defined as instance methods are deprecated.
singer-sdk 0.53's get_tap_test_class defines its `runner` fixture that
way, and with filterwarnings=error every SDK test errors at setup.
singer-sdk 0.54 makes it a classmethod; the ~=0.53.5 pin kept
Dependabot from offering that.

0.54 also:
- deprecates BaseOffsetPaginator in favour of OffsetPaginator (same
  constructor and get_next), so the paginator subclasses the new name
- warns on Python 3.10, which reached end of life in October 2026, so
  3.10 leaves requires-python, the classifiers (and with them the CI
  matrix) and the tox env list

uv.lock is regenerated with uv 0.13 to keep lockfile revision 5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@tobiascadee
tobiascadee force-pushed the tobias/singer-sdk-0.54 branch from 0c836e9 to 86a41bc Compare October 28, 2026 10:20
@tobiascadee
tobiascadee merged commit dbb83d0 into main Oct 28, 2026
8 checks passed
@tobiascadee
tobiascadee deleted the tobias/singer-sdk-0.54 branch October 28, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant