Draft
Conversation
… see much point in adding the other effects until i can actually modify physshapes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
This draft allows characters to be randomly-sized (and creating a slider/some sort of scaling in the character creation menu wouldn't be very hard), changing their height and width to proportional amounts. Why is this not a PR, and instead just a draft? Well, the physics component stores mass, based on the area of the associated fixture and the density of it. Therefore, changing the actual mass of something would be a pretty difficult task, made even more so by the fact that there aren't any elliptical PhysShapes. Not only that, but that means that I would be required to use dimensions instead of mass for things like health and blood volume, which I had planned to change.
Why / Balance
I believe that being able to scale characters is a realistic and fun way to add to character customization, though balancing will need to be enacted when it comes to things like, most notably, combat hitboxes.
Technical details
Media
Breaking changes
Changelog
🆑