SELinux: Use kernel_read_fs_sysctls interface instead custom policy

[grulja]

The kernel_read_fs_sysctls interface does exactly the same thing and we don't reinvent the wheel. It's also easier to maintain.

Supersedes #1918

[grulja]

CC @zpytela for double-check.

[zpytela]

Correct, also improves legibility and is just the correct way: For using types from other modules, including base, interfaces should be used.

Now similar changes should also apply to other parts, it may not be that easy this time.

[grulja]

Now similar changes should also apply to other parts, it may not be that easy this time.

What do you mean by that?

[zpytela]

👍

[zpytela]

Now similar changes should also apply to other parts, it may not be that easy this time.

What do you mean by that?

For using types from other modules interfaces should be used. No direct reference to gconf_home_t and admin_home_t.

[grulja]

Now similar changes should also apply to other parts, it may not be that easy this time.

What do you mean by that?

For using types from other modules interfaces should be used. No direct reference to gconf_home_t and admin_home_t.

I see. The use of gconf_home_t was introduced by 337c136, but admin_home_t is what I added recently.

What complications this can cause? Or is it just the right thing to do?

[zpytela]

What complications this can cause? Or is it just the right thing to do?

To ensure types from other modules are handled properly, e. g. when a particular module is disabled.

Certainly it is the right thing, improves legibility and maintenance etc.