Conversation
This test does not pass on this commit yet, but we should be able to get it to pass by increasing the universe's star-size.
Tim2othy
reviewed
Mar 30, 2025
Owner
There was a problem hiding this comment.
I have nothing against the star being influenced by planets gravity. Maybe we should do that instead of adding this test? If the star only contains 10% of the mass right now, then the game probably also wouldn't be fun if it was 99% of the mass, so maybe we shouldn't go for this much realism.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test resolves this comment: #80 (comment)
It tests whether the star contains > 99% of the mass in the universe, to justify it being immobile (I wonder why, though, would it be that bad to have the star be influenced by planets' gravity?). The test doesn't pass yet because the star contains about 0.2% of the mass in the small universe, and 10% of the mass in the large universe (I guess this is slightly random due to varying planet-sizes), so before we merge this, we'd probably have to make the stars larger or planets smaller.
You probably have a way better idea about what the game should feel like, would you mind adjusting the universe-constants to your tastes until the test passes, or decide that the "> 99% of mass" criterion is not necessary?