Improve performance of adding beats #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves by ~10x the speed of adding a beat at the start of a beat timeline with 300 beats.
…ent_data This value can be used by subclasses to determine if further computing is necessary
…sure for all beats
azfoo
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caches beat metric position and prevents redudant calls to
BeatTimeline.update_metric_fraction_dictto greatly improve performance when adding more beats to timelines with hundreds of beats.This is not a long-term solution to our performance issues, but it solves #321 for the use-case described. Where more precise beat annotations are required, the performance is still subpar.