feat: enhanced ruin & recreate #1976
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceo
commented
Dec 10, 2025
Collaborator
Author
triceo
left a comment
triceo
left a comment
There was a problem hiding this comment.
Minor comments. The bulk of the comments will be in Enterprise.
| this.ruinAndRecreatePickerClass = ruinAndRecreatePickerClass; | ||
| } | ||
|
|
||
| public @NonNull AdvancedListRuinRecreateMoveSelectorConfig withRuinAndRecreatePickerClass( |
Collaborator
Author
There was a problem hiding this comment.
Other selectors typically put the withers at the end of the class.
| import org.jspecify.annotations.NonNull; | ||
|
|
||
| @XmlType(propOrder = { | ||
| "ruinAndRecreatePickerClass", |
Collaborator
Author
There was a problem hiding this comment.
In the interest of brevity, why not just "pickerClass"?
We're already configuring RuinRecreateMoveSelector, I don't think we need to repeat that over and over.
Collaborator
Author
|
@Christopher-Chianelli Please remember to write documentation. I'd probably add this to the section about moves, add a disclaimer that it's an enterprise feature, and reference it in the enterprise section. |
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
triceo
commented
Dec 12, 2025
Comment on lines
+161
to
+162
| ADVANCED_RUIN_AND_RECREATE("Advanced ruin and recreate", | ||
| "remove advancedRuinRecreateMoveSelector and/or advancedListRuinRecreateMoveSelector from the solver configuration"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.