Ddir deduplication - #890
Merged
Merged
Conversation
`explain`'s `SCC` fixture and `lower`'s `lowers_scc_depth_two` source were byte-identical copies of `examples/programs/scc.ddp`, maintained by hand. Both now `include_str!` the example, so the fixture cannot drift from the program the rest of the tree runs. `tests/explain.rs`'s `SCC_ROW` stays inline: it is a different program (its export is the edge set, not the aggregate), as its comment says. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`value_contract` and `backstop` each defined the same `Mem` — a `Dataflow` over `Vec<(Value, Value)>` running projections and predicates through `ir::eval` with a nested-loop join — once formatted long and once short. They now share a single definition. `nested_contract` keeps its own: that one is a genuinely different model, with its own `Proj`/`Pred`. The module header also claimed the flat `[i64]` model "lives in `explain.rs` and reuses `folded`". There is no `explain.rs`, and `folded` is retired; the header now says `Val` is the only model the crate evaluates. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The stdin/TCP reader and the WebSocket reader each built the same prepare-and-send sequence: check for `exit`, `prepare`, build a `Request`, hand it to the control channel. They now call one `dispatch` returning `Continue`/`Exit`/`Disconnected`, and each loop decides what that means — the stdin/TCP reader stops, the WebSocket reader sets `should_exit` and keeps draining the current message. Behaviour is unchanged on both paths. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
`has_trace` has no callers: its identifier appears exactly once in the whole of `interactive/`, at its own definition. `backend`'s header still advertised "the example binaries, the server, and a wasm front-end" as drivers. There is no wasm anywhere in the tree and the example driver is retired (`server/src/main.rs:30` says so); the server is the one driver. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
frankmcsherry
marked this pull request as ready for review
September 20, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.