DDIR: remove dead code and stale comments - #898
Merged
Merged
Conversation
Deletions only; no behavior change except that the server no longer recognizes `query` or `drop <number>`, both of which only ever returned an error. - explain: drop the test-only second `RowModel` (`nested_contract`), the `backstop` test for a gap that is now implemented, and the invert fast path that `Val` never took (`lossy_try_invert` always returned `None`). - server: drop the reserved `query` command, the numeric form of `drop`, and the README note calling `explain` unimplemented. - Comments that describe history or no longer match the code: the retired flat `[i64]` model, `rows_to_batch`, `vec::evaluate`, a shape pass and design doc that don't exist, a test that doesn't exist, the chunker accumulating to `TARGET` (it is `INGEST`), probing costing `n log n`, the exchange/arrangement agreeing on primitive key ids, and a fused doc comment in chunk.rs. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deletions only; no behavior change except that the server no longer
recognizes
queryordrop <number>, both of which only ever returned anerror.
RowModel(nested_contract), thebackstoptest for a gap that is now implemented, and the invert fast paththat
Valnever took (lossy_try_invertalways returnedNone).querycommand, the numeric form ofdrop, andthe README note calling
explainunimplemented.flat
[i64]model,rows_to_batch,vec::evaluate, a shape pass anddesign doc that don't exist, a test that doesn't exist, the chunker
accumulating to
TARGET(it isINGEST), probing costingn log n, theexchange/arrangement agreeing on primitive key ids, and a fused doc comment
in chunk.rs.
Validation: workspace tests pass; clippy warning count unchanged.
🤖 Generated with Claude Code