Fix #163: incorrect light theme color in github sign in button in sign in page

[Karelaking]

📝 Description

🎯 Type of Change

• 🐛 Bug fix (non-breaking change that fixes an issue)
• ✨ New feature (non-breaking change that adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to change)
• 📚 Documentation update
• 🎨 UI/UX improvement
• ⚡ Performance improvement
• ♿ Accessibility improvement
• 🔧 Refactoring

🔗 Related Issues

Closes #163

📋 Changes Made

• Change 1
• Change 2
• Change 3

🧪 Testing

• Unit tests added/updated
• Tested on desktop
• Tested on mobile
• Manual testing completed

Testing Steps:

1. Step 1
2. Step 2
3. Step 3

🎨 Screenshots/Demo

📦 Dependencies

• No new dependencies
• New dependencies added (list below)
  • dependency-name@version

✅ Checklist

Code Quality

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I ran npm run lint and fixed all issues

Testing & Functionality

• I have tested my changes thoroughly
• New and existing tests pass locally with my changes
• I have added tests that prove my fix is effective or my feature works

Documentation

• I have updated the documentation accordingly
• I have updated the README if needed
• I have added/updated inline comments where necessary

Git & Commits

• My commits have clear, descriptive messages
• My branch is up to date with the base branch
• I have not included unnecessary commits

Breaking Changes

• This PR does not introduce breaking changes
• I have documented any breaking changes clearly

📝 Additional Context

🔍 Reviewer Notes

🚀 Deployment Notes

[vercel]

@Karelaking is attempting to deploy a commit to the Divya Tiwari's projects Team on Vercel.

A member of the Team first needs to authorize it.

[netlify]

✅ Deploy Preview for tiwaridivya25-devconnect ready!

Name	Link
🔨 Latest commit	f94893d
🔍 Latest deploy log	https://app.netlify.com/projects/tiwaridivya25-devconnect/deploys/697b1529ae18f80008cd310a
😎 Deploy Preview	https://deploy-preview-199--tiwaridivya25-devconnect.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

Thanks for creating a PR for your Issue! ☺️

We'll review it as soon as possible.
In the meantime, please double-check the file changes and ensure that all commits are accurate.

If there are any unresolved review comments, feel free to resolve them. 🙌🏼

[Copilot]

Pull request overview

Fixes the GitHub OAuth button’s hover styling in light theme (to keep the GitHub icon visible), while also refactoring some UI formatting and changing how the “create conversation” modal loads user lists.

Changes:

• Adjust GitHub social button icon container hover background in light theme on Login/Register pages.
• Reformat several JSX/template-string blocks for readability/consistency.
• Update CreateConversationModal to fetch users via the profiles table (with backend-availability guard) instead of the Supabase admin API.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
src/pages/LoginPage.tsx	Tweaks light-theme hover styling for the GitHub sign-in button (icon container) and applies formatting cleanups.
src/pages/RegisterPage.tsx	Mirrors the GitHub button hover styling fix from Login and applies formatting cleanups.
src/components/CreateConversationModal.tsx	Switches user fetching to a profiles table query with demo/back-end availability handling and minor formatting.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Users are mapped with email: '' for privacy, but this component still uses user.email for filtering and renders it in the list. This produces a blank secondary line and makes email search ineffective. Consider making email optional and updating filter/render to use available profile fields (e.g., full_name/username) instead.