Skip to content

Refactor/90/profile-edit#101

Merged
SeokChan-Lee merged 5 commits intomainfrom
refactor/90/profile-edit
Feb 12, 2025
Merged

Refactor/90/profile-edit#101
SeokChan-Lee merged 5 commits intomainfrom
refactor/90/profile-edit

Conversation

@SeokChan-Lee
Copy link
Collaborator

@SeokChan-Lee SeokChan-Lee commented Feb 11, 2025 •
edited
Loading

โ“์ด์Šˆ

โœ๏ธ Description

์ž‘์—… ๋‚ด์šฉ

  • ํ”„๋กœํ•„ ์ˆ˜์ • ์ปดํฌ๋„ŒํŠธ API ์—ฐ๋™
  • ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ Input, SubmitButton์œผ๋กœ ๊ต์ฒด
    • SubmitButton ์Šคํƒ€์ผ ๋ณ€๊ฒฝ์„ ์œ„ํ•ด className์„ prop์œผ๋กœ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • mypage์— ๋ฐฐ์น˜

Uploading แ„’แ…ชแ„†แ…งแ†ซ แ„€แ…ตแ„…แ…ฉแ†จ 2025-02-11 แ„‹แ…ฉแ„’แ…ฎ 6.45.19.movโ€ฆ

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

ํ”ผ๋“œ๋ฐฑ ๋ฐ˜์˜

  • ๋‹‰๋„ค์ž„ ์ˆ˜์ • ํ›„ ์ €์žฅ ์‹œ input๋ž€ ์ดˆ๊ธฐํ™”
  • ๊ธฐ์กด ํ”„๋กœํ•„ ์ด๋ฏธ์ง€๊ฐ€ ์žˆ๋Š” ๊ฒฝ์šฐ x ๋ฒ„ํŠผ์œผ๋กœ ์ด๋ฏธ์ง€ ์‚ญ์ œ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
2025-02-12.12.52.52.mov

@SeokChan-Lee SeokChan-Lee added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง labels Feb 11, 2025
@vercel
Copy link

vercel bot commented Feb 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 12, 2025 6:50am

@SeokChan-Lee
Copy link
Collaborator Author

SeokChan-Lee commented Feb 11, 2025

commit์„ ์ž‘์—… ๋ณ„๋กœ ๋ถ„ํ• ํ•ด์„œ ํ•ด์•ผ๋˜๋Š”๋ฐ ์Šต๊ด€์ด ์•ˆ๋˜์žˆ์–ด์„œ ํ•ญ์ƒ ๋๋‚˜๊ณ  ๋‚˜์„œ ํ•˜๋„ค์š” ใ… 

@SeokChan-Lee SeokChan-Lee self-assigned this Feb 11, 2025
ToKyun02
ToKyun02 reviewed Feb 11, 2025
View reviewed changes
Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž‘์—…ํ•˜์‹œ๋Š๋ผ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค! ๋ช‡๊ฐ€์ง€ ์ถ”๊ฐ€์‚ฌํ•ญ์ด ์žˆ์–ด์„œ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊น๋‹ˆ๋‹ค.

form์ด ์„ฑ๊ณต์ ์œผ๋กœ ์ œ์ถœ๋˜๋ฉด input๋ž€ ์ดˆ๊ธฐํ™” ๋˜์—ˆ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค!

์ด๋ฏธ์ง€ ๋ฏธ๋ฆฌ๋ณด๊ธฐ x๋ฒ„ํŠผ ํด๋ฆญ ์‹œ ์ด๋ฏธ์ง€๊ฐ€ ์‚ฌ๋ผ์ง€์ง€ ์•Š๋Š”๋ฐ, ์ด ๋ถ€๋ถ„๋„ ๊ฐœ์„  ์ž‘์—… ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค!

ToKyun02
ToKyun02 reviewed Feb 12, 2025
View reviewed changes
Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž‘์—…ํ•˜์‹œ๋Š๋ผ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

๋ช‡๊ฐ€์ง€ ์ถ”๊ฐ€ ๊ฐœ์„  ์‚ฌํ•ญ์ด ์žˆ๋Š” ๊ฒƒ ๊ฐ™์•„ ์ฝ”๋ฉ˜ํŠธ ๋‚จ๊น๋‹ˆ๋‹ค!

ToKyun02
ToKyun02 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณ€๊ฒฝ์‚ฌํ•ญ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@SeokChan-Lee SeokChan-Lee merged commit 4f36359 into main Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ToKyun02 ToKyun02 ToKyun02 approved these changes

Assignees

@SeokChan-Lee SeokChan-Lee

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor: ํ”„๋กœํ•„ ์ˆ˜์ • ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„  ์ž‘์—…

2 participants

@SeokChan-Lee @ToKyun02