Skip to content

Comments

Fix/92/alert improve#112

Merged
cksrlcks merged 3 commits intomainfrom
fix/92/alert
Feb 12, 2025
Merged

Fix/92/alert improve#112
cksrlcks merged 3 commits intomainfrom
fix/92/alert

Conversation

@cksrlcks
Copy link
Collaborator

โ“์ด์Šˆ

โœ๏ธ Description

  • alert์„ awaitํ• ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„  (await์„ ์จ๋„๋˜๊ณ  ์•ˆ์จ๋„ ๋ฉ๋‹ˆ๋‹ค.)
  • ๋ชจ๋‹ฌ์ „์ฒด์ ์œผ๋กœ ๋ชจ๋‹ฌ์ด ๋„์›Œ์ง€๋ฉด ๋ชจ๋‹ฌ๋‚ด๋ถ€์˜ ํฌ์ปค์Šค๊ฐ€๋Šฅํ•œ ์ฒซ๋ฒˆ์งธ ์š”์†Œ์— ํฌ์ปค์‹ฑ์ด๋™
    • alert๋ชจ๋‹ฌ์˜๊ฒฝ์šฐ ํ™•์ธ๋ฒ„ํŠผ์œผ๋กœ ํฌ์ปค์‹ฑ๋˜์–ด ์—”ํ„ฐ๋กœ ๋‹ซ์„์ˆ˜์žˆ์Œ
    • ๋กœ๊ทธ์ธ ํผ์ œ์ถœ์˜ ์—”ํ„ฐ๋กœ ์—ฌ๋Ÿฌ๋ฒˆ ์ œ์ถœ๋˜๋Š”์ƒํ™ฉ ๋ฐฉ์ง€ (๋ชจ๋‹ฌ๋กœ ํฌ์ปค์‹ฑ์ด ๋„˜์–ด๊ฐ€์„œ ์—”ํ„ฐ๋ฅผ ์•„๋ฌด๋ฆฌ์ณ๋„ ํผ์ œ์ถœ์ด ์•ˆ๋ฉ๋‹ˆ๋‹ค. )

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@cksrlcks cksrlcks added Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Bug ๐Ÿ› ๋ฒ„๊ทธ Type: Improve UX โฌ†๏ธ UX ๊ฐœ์„  labels Feb 12, 2025
@cksrlcks cksrlcks requested a review from ToKyun02 February 12, 2025 01:05
@cksrlcks cksrlcks self-assigned this Feb 12, 2025
@cksrlcks cksrlcks linked an issue Feb 12, 2025 that may be closed by this pull request
2 tasks
@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 12, 2025 5:11am

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐœ์„  ์‚ฌํ•ญ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

์ž‘์—…ํ•˜์‹œ๋А๋ผ ๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!

@cksrlcks cksrlcks merged commit cf06189 into main Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Bug ๐Ÿ› ๋ฒ„๊ทธ Type: Improve UX โฌ†๏ธ UX ๊ฐœ์„ 

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix : useAlert ๊ฐœ์„ 

2 participants