Skip to content

Comments

Feat/111/header#118

Merged
cksrlcks merged 8 commits intomainfrom
feat/111/header
Feb 12, 2025
Merged

Feat/111/header#118
cksrlcks merged 8 commits intomainfrom
feat/111/header

Conversation

@cksrlcks
Copy link
Collaborator

โ“์ด์Šˆ

โœ๏ธ Description

ํ—ค๋” ์ปดํฌ๋„ŒํŠธ ์ž‘์—…์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ๊ด€๋ฆฌ ํŽ˜์ด์ง€ ์—ฐ๊ฒฐ
  • ์ดˆ๋Œ€ํ•˜๊ธฐ ๋ชจ๋‹ฌ ์—ฐ๊ฒฐ
  • ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ์—ฐ๊ฒฐ (๋ฆฌ์•กํŠธ์ฟผ๋ฆฌ ์บ์‹œ ๋ฌดํšจํ™” ์ด์Šˆ๋„ ๊ฐ™์ด ์ฒ˜๋ฆฌ)
  • ๋ผ์šฐํŒ…์— ๋”ฐ๋ฅธ ์กฐ๊ฑด๋ถ€ ๋žœ๋”๋ง
  • ๋งด๋ฒ„๋ฆฌ์ŠคํŠธ ์—ฐ๊ฒฐ

๋ผ์šฐํŒ…์— ๋”ฐ๋ฅธ ์กฐ๊ฑด๋ถ€ ๋žœ๋”๋ง
ํŽ˜์ด์ง€ ํƒ€์ดํ‹€

  • page id (userParam์œผ๋กœ ์ฒดํฌ)๊ฐ€ ์žˆ๋Š” ๊ฒฝ์šฐ์—๋Š” ๋Œ€์‹œ๋ณด๋“œ ๋ฐ์ดํ„ฐ์˜ ์ œ๋ชฉ์œผ๋กœ ์ œ๊ณต
  • ๋‚˜๋จธ์ง€ ํŽ˜์ด์ง€๋“ค์€ useSelectedLayoutSegment hook์œผ๋กœ segment์— ๋งž๋Š” ํƒ€์ดํ‹€ ์ œ๋ชฉ ๋งตํ•‘ํ•ด์„œ ๋…ธ์ถœ
  • ๊ด€๋ฆฌ, ์ดˆ๋Œ€ํ•˜๊ธฐ ๋ฒ„ํŠผ์€ ๋Œ€์‹œ๋ณด๋“œ ์ฃผ์ธ๋งŒ ๋ณด์ด๋„๋ก ํ•จ (์ผ๋ฐ˜๋งด๋ฒ„๊ฐ€ ์ดˆ๋Œ€ํ•˜์ง€ ๋ชปํ•จ - ๊ถŒํ•œ๋ฌธ์ œ๋œธ)

์ „๋‹ฌ์‚ฌํ•ญ
๊ธฐ์กด ์„์ฐฌ๋‹˜์ด ์ž‘์—…ํ•˜์‹  ์ปดํฌ๋„ŒํŠธ์•ˆ์— ํ•„์š”ํ•œ ๋‚ด์šฉ๋งŒ ๋ถ„๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-02-12 แ„‹แ…ฉแ„’แ…ฎ 7 28 46
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-02-12 แ„‹แ…ฉแ„’แ…ฎ 7 29 02
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-02-12 แ„‹แ…ฉแ„’แ…ฎ 7 35 40
image

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@cksrlcks cksrlcks added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง labels Feb 12, 2025
@cksrlcks cksrlcks self-assigned this Feb 12, 2025
@cksrlcks cksrlcks linked an issue Feb 12, 2025 that may be closed by this pull request
5 tasks
@vercel
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 12, 2025 10:45am

Copy link
Collaborator

@SeokChan-Lee SeokChan-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์†์ด ์ง„์งœ ๋น ๋ฅด์‹œ๋„ค์š”
์ผ๋‹จ ์ œ๊ฐ€ ํ™•์ธํ–ˆ์„๋• ๊ธฐ๋Šฅ์ƒ์œผ๋กœ ์ „ํ˜€ ๋ฌธ์ œ์—†์–ด ๋ณด์ž…๋‹ˆ๋‹ค ๐Ÿ‘
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค !

@cksrlcks cksrlcks merged commit 7368e90 into main Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

2 participants