Conversation
- useAlert 개선 - useConfirm 추가 - modalStore 개선 - DialogContainer 개선
cksrlcks
added
Priority: Medium 🔖
Closed
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- buttons 디폴트값을 지정
ToKyun02
approved these changes
Feb 13, 2025
Owner
ToKyun02
left a comment
ToKyun02
left a comment
There was a problem hiding this comment.
변경하신 내용확인했습니다!
작업하시느라 고생하셨습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓이슈
✍️ Description
작업내용
개선한방법
dialog가 열리면 promise를 생성하고, resolve와 reject를 state에 추가하여,
dialog 확인, 취소버튼에서 각각 resolve와 reject를 실행하도록 했습니다.
resolve, reject둘다 dialog가 닫히도록 state를 조작하며, 각각 true, false를 반환하여
confirm, alert을 사용하는 쪽에서 활용이 가능합니다.
변경된 훅내용으로 수정한 페이지들
✅ Checklist
PR
Test
Additional Notes