Merged
Conversation
rak517
added
Priority: Medium ๐
|
The latest updates on your projects. Learn more about Vercel for Git โ๏ธ
|
ToKyun02
reviewed
Feb 13, 2025
Owner
There was a problem hiding this comment.
์์ ํ์๋๋ผ ๊ณ ์ ๋ง์ผ์ จ์ต๋๋ค!
comment api ์ฌ์ฉํ ๋ ๋ฆฌ์กํธ ์ฟผ๋ฆฌ ์ฌ์ฉํด์ผ ํ ๊ฒ ๊ฐ์ต๋๋ค!
์นด๋๋ฅผ ๋ซ์๋ค๊ฐ ๋ค์ ๋ค์ด์ค๋ฉด ์ฌ ํ์นญ๋๋๊ฑธ ๋ฐฉ์งํ๋ ๋ชฉ์ ๋ ์์ด์ฉ
์ง๊ธ์ ์์ง ๋ ๋๋ง๋ง ๋ณด๋ ๋จ๊ณ์ธ ๊ฒ ๊ฐ์์ ์ถํ ๋ค๋ฅธ API ์ฌ์ฉํ ๋ ์ ์ฉํด๋ ๋ ๊ฒ ๊ฐ์ต๋๋ค!
cards์ ๊ฒฝ์ฐ ์ ๊ฐ ์ง๊ธ ์์ ์ค์ธ ์ด์์์ ์ฟผ๋ฆฌ ์์ฑ์๋ฃํ์ต๋๋ค
* โป๏ธ refactor : ์ด๋ฏธ์ง ์ ๋ก๋ ๊ฐ์ - ํ์ ์ null ์ถ๊ฐ (api์์ ์๋ต์ด null์ด ์ฌ ์ ์์) - ์ฟผ๋ฆฌ ๊ฐ์ (zod validation์ ์ฉ๋ ์ถ๊ฐ) - defaultValue ์ถ๊ฐ (์ถ๊ฐ๋ก ์ฌ๋ฆฐ ์ด๋ฏธ์ง๋ฅผ ์ง์ฐ๋ฉด, ์๋ ์ด๋ฏธ์ง๊ฐ ๋ณด์ด๊ฒ) * โป๏ธ refactor : ๋ด์ ๋ณด ํ์ด์ง ๊ฐ์ - ๋ด์ ๋ณด๋ฅผ ssr๋ก ๋ถ๋ฌ์ค๋๋ก ๊ฐ์ - ํผ๋ด๋ถ ๊ณต์ฉ ์ปดํฌ๋ํธ๋ก ๊ต์ฒด - ํผ๋ด๋ถ ๋ก์ง ๊ฐ์ * ๐ fix : ํค๋ ๋ด์ ๋ณด์ ํ๋กํ ์ด๋ฏธ์ง ๋ ธ์ถ ์ถ๊ฐ
Co-authored-by: chanki.kim <chanki.kim89@gmail.com>
ToKyun02
approved these changes
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
โ์ด์
โ๏ธ Description
โ Checklist
PR
Test
Additional Notes