Skip to content

Fix/119/sidebar#128

Merged
cksrlcks merged 1 commit intomainfrom
fix/119/sidebar
Feb 13, 2025
Merged

Fix/119/sidebar#128
cksrlcks merged 1 commit intomainfrom
fix/119/sidebar

Conversation

@SeokChan-Lee
Copy link
Collaborator

โ“์ด์Šˆ

โœ๏ธ Description

์ž‘์—… ๋‚ด์šฉ

  • usePathname์œผ๋กœ ๋ฐฉ๋ฌธ์ค‘์ธ ๋Œ€์‹œ๋ณด๋“œ๋ฅผ ์‚ฌ์ด๋“œ๋ฐ”์— ํ‘œ์‹œํ•˜๋˜๊ฑธ useParams๋กœ ๋ณ€๊ฒฝ
    • dashboard/id/edit ๋“ฑ ์ถ”๊ฐ€ ์ง„์ž… ์‹œ ํ‘œ์‹œ๊ฐ€ ๊บผ์ง€๋Š” ์˜ค๋ฅ˜ ํ•ด๊ฒฐ

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@SeokChan-Lee SeokChan-Lee self-assigned this Feb 13, 2025
@vercel
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 13, 2025 0:08am

@SeokChan-Lee SeokChan-Lee added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Bug ๐Ÿ› ๋ฒ„๊ทธ labels Feb 13, 2025
Copy link
Collaborator

@cksrlcks cksrlcks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ๊ตฟ

@cksrlcks cksrlcks merged commit aa0a3bb into main Feb 13, 2025
3 checks passed
rak517 added a commit that referenced this pull request Feb 13, 2025
* โœจ feat: ํ• ์ผ ์นด๋“œ ๋ชจ๋‹ฌ ์ƒ์„ฑ

* โœจ feat: ํ•  ์ผ ์นด๋“œ ์ƒ์„ธ์ •๋ณด ๋ชจ๋‹ฌ ๊ตฌํ˜„

* ๐Ÿ› fix: ๋“œ๋กญ๋‹ค์šด, ์ด๋ฏธ์ง€ ์ˆ˜์ •

* ๐Ÿ”ฅ remove: ๋ถˆํ•„์š”ํ•œ console.log ์‚ญ์ œ

* โ™ป๏ธ refactor: confirm ์‚ฌ์šฉ ๋ถ€๋ถ„ useConfirm์œผ๋กœ ๊ต์ฒด

* Feat/40/mypage refactor (#126)

* โ™ป๏ธ refactor : ์ด๋ฏธ์ง€ ์—…๋กœ๋“œ ๊ฐœ์„ 
- ํƒ€์ž…์— null ์ถ”๊ฐ€ (api์—์„œ ์‘๋‹ต์ด null์ด ์˜ฌ ์ˆ˜ ์žˆ์Œ)
- ์ฟผ๋ฆฌ ๊ฐœ์„  (zod validation์— ์šฉ๋Ÿ‰ ์ถ”๊ฐ€)
- defaultValue ์ถ”๊ฐ€ (์ถ”๊ฐ€๋กœ ์˜ฌ๋ฆฐ ์ด๋ฏธ์ง€๋ฅผ ์ง€์šฐ๋ฉด, ์›๋ž˜ ์ด๋ฏธ์ง€๊ฐ€ ๋ณด์ด๊ฒŒ)

* โ™ป๏ธ refactor : ๋‚ด์ •๋ณด ํŽ˜์ด์ง€ ๊ฐœ์„ 
- ๋‚ด์ •๋ณด๋ฅผ ssr๋กœ ๋ถˆ๋Ÿฌ์˜ค๋„๋ก ๊ฐœ์„ 
- ํผ๋‚ด๋ถ€ ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ๋กœ ๊ต์ฒด
- ํผ๋‚ด๋ถ€ ๋กœ์ง ๊ฐœ์„ 

* ๐Ÿ› fix : ํ—ค๋” ๋‚ด์ •๋ณด์— ํ”„๋กœํ•„ ์ด๋ฏธ์ง€ ๋…ธ์ถœ ์ถ”๊ฐ€

* ๐Ÿ› fix: useParams๋กœ ๋ฐฉ๋ฌธ์ค‘์ธ ๋Œ€์‹œ๋ณด๋“œ ํ‘œ์‹œ ๊ฐœ์„  (#128)

Co-authored-by: chanki.kim <chanki.kim89@gmail.com>

* ๐Ÿ’„ style: ๋กœ๊ทธ์ธ,ํšŒ์›๊ฐ€์ž… ํŽ˜์ด์ง€ ๋กœ๊ณ  png->svg๋ณ€๊ฒฝ (#125)

* โ™ป๏ธ refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜

* ๐Ÿ› fix: Avartor ์ปดํฌ๋„ŒํŠธ profileImageUrl ์˜ค๋ฅ˜ ํ•ด๊ฒฐ

---------

Co-authored-by: ๊น€์ฐฌ๊ธฐ (Chanki Kim) <44834561+cksrlcks@users.noreply.github.com>
Co-authored-by: SeokChan-Lee <melee0826@gmail.com>
Co-authored-by: chanki.kim <chanki.kim89@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Bug ๐Ÿ› ๋ฒ„๊ทธ

Projects

None yet

2 participants