Skip to content

Comments

Ux/123/datepicker custom#134

Merged
cksrlcks merged 3 commits intomainfrom
ux/123/datepicker-custom
Feb 14, 2025
Merged

Ux/123/datepicker custom#134
cksrlcks merged 3 commits intomainfrom
ux/123/datepicker-custom

Conversation

@cksrlcks
Copy link
Collaborator

@cksrlcks cksrlcks commented Feb 14, 2025

โ“์ด์Šˆ

๋ฐ์ดํŠธํ”ผ์ปค ์ปค์Šคํ…€ ์ž‘์—…์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • locale ์„ค์ •์„ ์œ„ํ•ด date-fns ํŒจํ‚ค์ง€ ์ถ”๊ฐ€ (react datepicker๊ฐ€ ์ด ํŒจํ‚ค์ง€์— ์˜์กดํ•˜๋„ค์š”)
  • ํ—ค๋”์˜์—ญ์€ ์ปค์Šคํ…€๋žœ๋”๋กœ ์ƒˆ๋กœ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค. (๊ธฐ์กด ํ—ค๋”์— ๋ฒ„ํŠผ์ด ์•ฑ์†”๋กœ ๋•์ง€๋•์ง€๋ผ์„œ ์Šคํƒ€์ผ๋ง์ด ์ด์ƒํ•ด์„œ)
  • ์ผ์š”์ผ, ํ† ์š”์ผ์„ ์ƒ‰์„ ๊ตฌ๋ถ„ํ•˜๊ธฐ์œ„ํ•ด์„œ dayjs๋กœ ์š”์ผ๋ช… ์ถ”์ถœํ›„ ํด๋ž˜์Šค๋„ค์ž„์œผ๋กœ ๋ถ™์˜€์Šต๋‹ˆ๋‹ค.
  • /form ํŽ˜์ด์ง€์—์„œ ํ™•์ธ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@cksrlcks cksrlcks added Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Improve UX โฌ†๏ธ UX ๊ฐœ์„  labels Feb 14, 2025
@cksrlcks cksrlcks requested a review from ToKyun02 February 14, 2025 01:56
@cksrlcks cksrlcks self-assigned this Feb 14, 2025
@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 14, 2025 1:56am

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local์„ค์ • ๋ฐ ํŒ์—… ์ฐฝ ์Šคํƒ€์ผ๋ง ํ•˜์‹  ๊ฑฐ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค!

๋””์ž์ธ๋„ ์˜ˆ์˜๊ฒŒ ์ž˜ํ•ด์ฃผ์…จ๋„ค์š” ใ…Žใ…Ž

@cksrlcks cksrlcks merged commit 77e70a2 into main Feb 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Improve UX โฌ†๏ธ UX ๊ฐœ์„ 

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ux: DatePicker ์Šคํƒ€์ผ๋ง

2 participants