Skip to content

Feat/130/todo edit modal#146

Merged
rak517 merged 9 commits intomainfrom
feat/130/todo-edit-modal
Feb 15, 2025
Merged

Feat/130/todo edit modal#146
rak517 merged 9 commits intomainfrom
feat/130/todo-edit-modal

Conversation

@rak517
Copy link
Collaborator

@rak517 rak517 commented Feb 14, 2025

โ“์ด์Šˆ

โœ๏ธ Description

  • ํ•  ์ผ ์นด๋“œ์˜ ์ •๋ณด๋ฅผ ์ˆ˜์ •ํ•˜๋Š” ๋ชจ๋‹ฌ์„ ๊ตฌํ˜„ํ•ฉ๋‹ˆ๋‹ค

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@rak517 rak517 added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Feb 14, 2025
@rak517 rak517 requested a review from ToKyun02 February 14, 2025 09:51
@rak517 rak517 self-assigned this Feb 14, 2025
@vercel
Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 15, 2025 6:00am

ToKyun02
ToKyun02 previously approved these changes Feb 15, 2025
Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ธฐ๋Šฅ ๊ฒ€ํ†  ์™„๋ฃŒํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

Assign input์€ ์ œ๊ฐ€ ์ˆ˜์ •์ž‘์—… ์™„๋ฃŒํ–ˆ๊ณ , ๋‚˜์ค‘์— ์ œ ๋ธŒ๋žœ์น˜ ๋ณ‘ํ•ฉ๋˜๋ฉด ์ ์šฉํ•˜์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
(defaultAssignee ์„ค์ • ๊ฐ€๋Šฅํ•˜๋„๋ก ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค.)

์ถ”๊ฐ€์ ์œผ๋กœ, form์ˆ˜์ •์ด ์—†์œผ๋ฉด submit ๋ชปํ•˜๊ฒŒ ํ•ด์ฃผ์…จ์Œ ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค!

๋ฆฌ์•กํŠธ ํ›… ํผ์˜ ํผ ์ƒํƒœ์ธ isDirty์“ฐ์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šด๋‹ค!

@ToKyun02 ToKyun02 dismissed their stale review February 15, 2025 03:19

์ˆ˜์ • ์‚ฌํ•ญ์ด ๋” ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค.

cksrlcks and others added 5 commits February 15, 2025 14:30
* ๐Ÿ› fix : ๋ฏธ๋“ค์›จ์–ด ์ˆ˜์ •

* ๐Ÿ› fix : ๋กœ๊ทธ์ธ, ๋กœ๊ทธ์•„์›ƒ์‹œ ์ƒˆ๋กœ๊ณ ์นจ ์ถ”๊ฐ€
* ๐Ÿ’„ style : ์Šค์ผˆ๋ ˆํ†ค ์ปดํฌ๋„ŒํŠธ ์ž‘์—…

* ๐Ÿ’„ feat : ๋‚ด์ •๋ณด, ๋Œ€์‹œ๋ณด๋“œ ๊ด€๋ฆฌ ํŽ˜์ด์ง€ ์Šค์ผˆ๋ ˆํ†ค ์ปดํฌ๋„ŒํŠธ ์ถ”๊ฐ€
* ๐Ÿ› fix : avatar ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„ 
- nickname์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 

* ๐Ÿ› fix : default value ์ถ”๊ฐ€
Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž‘์—… ๋‚ด์šฉ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@rak517 rak517 merged commit 12985af into main Feb 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: ํ•  ์ผ ์นด๋“œ ์ˆ˜์ • ๋ชจ๋‹ฌ ๊ตฌํ˜„

3 participants