Skip to content

Fix/149/Avatar#150

Merged
cksrlcks merged 2 commits intomainfrom
fix/149/avatar
Feb 15, 2025
Merged

Fix/149/Avatar#150
cksrlcks merged 2 commits intomainfrom
fix/149/avatar

Conversation

@cksrlcks
Copy link
Collaborator

โ“์ด์Šˆ

โœ๏ธ Description

โœ… Checklist

์•„๋ฐ”ํƒ€ ์ปดํฌ๋„ŒํŠธ๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • nickname์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 
  • ์•„๋ฐ”ํƒ€ ์ปดํฌ๋„ŒํŠธ์˜ ํƒ€์ž…์„ User ํƒ€์ž…์—์„œ ์ถ”๋ก ํ•˜๋„๋ก ๊ฐœ์„ 
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-02-15 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 11 27 20

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

- nickname์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 
@cksrlcks cksrlcks added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Bug ๐Ÿ› ๋ฒ„๊ทธ labels Feb 15, 2025
@cksrlcks cksrlcks requested a review from ToKyun02 February 15, 2025 02:30
@cksrlcks cksrlcks self-assigned this Feb 15, 2025
@cksrlcks cksrlcks linked an issue Feb 15, 2025 that may be closed by this pull request
1 task
@vercel
Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 15, 2025 2:46am

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Props๊ฐ€ ์ „๋ถ€ ์„ ํƒ์‚ฌํ•ญ์ด๋ผ
ํ”„๋กœํ•„ ์ด๋ฏธ์ง€๋งŒ prop์œผ๋กœ ๋‚ด๋ ค์ฃผ๋Š”๊ฒƒ์ด ๊ฐ€๋Šฅํ•ด์ง„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๊ทธ๋Ÿด ๊ฒฝ์šฐ, ์ด๋ฏธ์ง€ ๋กœ๋”ฉ์ด ๋˜์ง€์•Š๋Š”๋‹ค๋ฉด alt๊ฐ€ ๋นˆ๋ฌธ์ž์—ด์ด ๋˜๋Š”๋ฐ alt์ชฝ ์ˆ˜์ •์ด ํ•„์š”ํ•ด๋ณด์ž…๋‹ˆ๋‹ค!

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ณ€๊ฒฝ ์‚ฌํ•ญ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@cksrlcks cksrlcks merged commit 29e16d9 into main Feb 15, 2025
3 checks passed
rak517 pushed a commit that referenced this pull request Feb 15, 2025
* ๐Ÿ› fix : avatar ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„ 
- nickname์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 

* ๐Ÿ› fix : default value ์ถ”๊ฐ€
rak517 added a commit that referenced this pull request Feb 15, 2025
* โœจ feat: ํ•  ์ผ ์ˆ˜์ • ๋ชจ๋‹ฌ UI ๊ตฌํ˜„

* โœจ feat: ํ•  ์ผ ์นด๋“œ ์ˆ˜์ • ๋ชจ๋‹ฌ ๊ธฐ๋Šฅ ๊ตฌํ˜„

* ๐Ÿ› fix: ์นด๋“œ ์ƒ์„ธ์ •๋ณด ์ปฌ๋Ÿผ ์ƒํƒœ ํ‘œ์‹œ ์ˆ˜์ •

* Fix/144/route cache clear (#145)

* ๐Ÿ› fix : ๋ฏธ๋“ค์›จ์–ด ์ˆ˜์ •

* ๐Ÿ› fix : ๋กœ๊ทธ์ธ, ๋กœ๊ทธ์•„์›ƒ์‹œ ์ƒˆ๋กœ๊ณ ์นจ ์ถ”๊ฐ€

* ๐Ÿ“ docs : README.md ๋ฌธ์„œ ๋ณด์ถฉ ๋ฐ ๊ฐœ์š” ์ˆ˜์ • (#143)

* Ux/147/skeleton (#148)

* ๐Ÿ’„ style : ์Šค์ผˆ๋ ˆํ†ค ์ปดํฌ๋„ŒํŠธ ์ž‘์—…

* ๐Ÿ’„ feat : ๋‚ด์ •๋ณด, ๋Œ€์‹œ๋ณด๋“œ ๊ด€๋ฆฌ ํŽ˜์ด์ง€ ์Šค์ผˆ๋ ˆํ†ค ์ปดํฌ๋„ŒํŠธ ์ถ”๊ฐ€

* Fix/149/Avatar (#150)

* ๐Ÿ› fix : avatar ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„ 
- nickname์„ ๋ฐ›์„ ์ˆ˜ ์žˆ๋„๋ก ๊ฐœ์„ 

* ๐Ÿ› fix : default value ์ถ”๊ฐ€

* โ™ป๏ธ refactor: form ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†์œผ๋ฉด submit ๋ชปํ•˜๊ฒŒ ์ˆ˜์ •

* โ™ป๏ธ refactor: ์ด๋ฏธ์ง€ ๋กœ์ง ์ˆ˜์ •

---------

Co-authored-by: ๊น€์ฐฌ๊ธฐ (Chanki Kim) <44834561+cksrlcks@users.noreply.github.com>
Co-authored-by: Kim To Kyun <58878190+ToKyun02@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Bug ๐Ÿ› ๋ฒ„๊ทธ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix : ์•„๋ฐ”ํƒ€ ์ปดํฌ๋„ŒํŠธ ๊ฐœ์„ 

2 participants