Skip to content

Comments

Refactor/137/project refactoring#172

Merged
cksrlcks merged 13 commits intomainfrom
refactor/137/project-refactoring
Feb 18, 2025
Merged

Refactor/137/project refactoring#172
cksrlcks merged 13 commits intomainfrom
refactor/137/project-refactoring

Conversation

@cksrlcks
Copy link
Collaborator

โ“์ด์Šˆ

โœ๏ธ Description

๊ณตํ†ต

  • ์ž„ํฌํŠธ ์ˆœ์„œ์ •๋ฆฌ (react-next-lib-hook-api-util-component-constant-type-asset)
  • ์ƒ๋Œ€๊ฒฝ๋กœ ์ž„ํฌํŠธ -> alias๋ฅผ ํ†ตํ•œ ์ ˆ๋Œ€๊ฒฝ๋กœ๋กœ ๋ณ€๊ฒฝ
  • ์•ˆ์“ฐ๋Š” ํŒŒ์ผ ์ œ๊ฑฐ
  • ํด๋”๋ช…๊ณผ ์ด๋ฆ„์ด ์ค‘๋ณต๋˜๋Š” ์ปดํฌ๋„ŒํŠธ๋Š” index.tsx๋กœ ๋ณ€๊ฒฝ
  • ํ™•์žฅ์ž ์ •๋ฆฌ

components/dashboardํด๋”์ •๋ฆฌ

  • todo card ๊ด€๋ จ ํŒŒ์ผ ๋ถ„๋ฆฌ
  • header, sidebar ํด๋” ์ถ”๊ฐ€ (๊ธฐ์กด dashboard-header ํด๋”๋‚ด ์ปดํฌ๋„ŒํŠธ ๊ฐ€์ ธ์˜ด)

constantsํด๋”์ •๋ฆฌ

  • path.ts -> todo.ts ์ด๋ฆ„ ๋ณ€๊ฒฝํ›„, todo์— ํ•„์š”ํ•œ ์ƒ์ˆ˜๋งŒ ๋‚จ๊น€ (๊ธฐ์กด path์•ˆ์— ์žˆ๋˜ ํ™”์‚ดํ‘œ svg ์ฝ”๋“œ๋Š” ์‚ฌ์šฉํ•˜๋Š” pagination ์ปดํฌ๋„ŒํŠธ ์ƒ๋‹จ์œผ๋กœ ์ด๋™)
  • profileEdit.ts -> user.ts ์ด๋ฆ„๋ณ€๊ฒฝ

forwardRef ์ œ๊ฑฐ

  • ๋ชจ๋‹ฌ forwardRef ์ œ๊ฑฐ
  • ํ•„๋“œ forwardRef ์ œ๊ฑฐ

utils

  • errorMessage.ts ์ด๋™ (utils/network ๋‚ด๋ถ€๋กœ ์ด๋™)

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@cksrlcks cksrlcks added Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง labels Feb 18, 2025
@cksrlcks cksrlcks self-assigned this Feb 18, 2025
@vercel
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 18, 2025 1:19am

Copy link
Collaborator

@SeokChan-Lee SeokChan-Lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค !

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌํŒฉํ† ๋ง ์‚ฌํ•ญ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

@cksrlcks cksrlcks merged commit 5459914 into main Feb 18, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: forwardRef ์ œ๊ฑฐ Refactor: ํ”„๋กœ์ ํŠธ ํด๋” ๊ตฌ์กฐ ์ •๋ฆฌ

4 participants