Skip to content

Comments

Feat/13/dashboard header#25

Merged
SeokChan-Lee merged 4 commits intomainfrom
feat/13/dashboard-header
Feb 5, 2025
Merged

Feat/13/dashboard header#25
SeokChan-Lee merged 4 commits intomainfrom
feat/13/dashboard-header

Conversation

@SeokChan-Lee
Copy link
Collaborator

@SeokChan-Lee SeokChan-Lee commented Feb 4, 2025

โ“์ด์Šˆ

โœ๏ธ Description

๋Œ€์‹œ๋ณด๋“œ ๊ณต์šฉ ํ—ค๋” ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„ํ•˜์—ฌ PR ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค.

์ž‘์—… ์‚ฌํ•ญ

  • ๋Œ€์‹œ๋ณด๋“œ ํ—ค๋” ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„
  • ๋ฐ˜์‘ํ˜• ๊ตฌํ˜„
  • ์ปดํฌ๋„ŒํŠธ ๋ผ์šฐํ„ฐ์— ๋”ฐ๋ผ title์ด ๋ณ€๊ฒฝ๋˜๋„๋ก ๊ตฌํ˜„
  • ์„ฑ๋ฝ๋‹˜๊ป˜์„œ ๋งŒ๋“œ์‹  ์ž„์‹œ mydashboard์— ์ถ”๊ฐ€ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.

์šฐ์„  API์—ฐ๋™ ์ž‘์—… ์ „๊นŒ์ง€ mock๋ฐ์ดํ„ฐ๋กœ ๋ฉค๋ฒ„์•„์ด์ฝ˜๊ณผ ์‚ฌ์šฉ์ž ํ”„๋กœํ•„์„ ์„ค์ •ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.
๋ฐ˜์‘ํ˜•์ด ์•„์ง ์–ด์ƒ‰ํ•œ ๋ถ€๋ถ„์ด ๋งŽ์•„ ์ถ”ํ›„ ์ถ”๊ฐ€ ์ž‘์—…์„ ์ง„ํ–‰ํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
์‚ฌ์ด๋“œ๋ฐ”์™€ ํ•ฉ์ณ์ง€๋‹ˆ ์Šคํƒ€์ผ์ด ์กฐ๊ธˆ ์–ด์ƒ‰ํ•œ ๋ถ€๋ถ„์ด ์žˆ์Šต๋‹ˆ๋‹ค. ์ด๊ฒƒ๋„ ์ถ”๊ฐ€๋กœ ์ˆ˜์ •ํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

image
image
image

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • Image ์ปดํฌ๋„ŒํŠธ width, height prop ์ˆ˜์ •
  • ์ฃผ์„ ๋‚ด์šฉ -> TODO๋กœ ์ˆ˜์ •
  • ์ปดํฌ๋„ŒํŠธ ์„ธ๋ถ„ํ™”

@SeokChan-Lee SeokChan-Lee requested a review from ToKyun02 February 4, 2025 17:39
@SeokChan-Lee SeokChan-Lee self-assigned this Feb 4, 2025
@vercel
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 5, 2025 5:50am

@SeokChan-Lee
Copy link
Collaborator Author

์ถ”๊ฐ€๋กœ ํ˜„์žฌ ๋Œ€์‹œ๋ณด๋“œ ํ—ค๋” ์ปดํฌ๋„ŒํŠธ ๋„ค์ด๋ฐ์ด Header๋กœ ๋˜์–ด ์žˆ๋Š”๋ฐ Dashboard-header๋กœ ํ•˜๋ฉด ๋„ˆ๋ฌด ๊ธด๊ฑฐ ๊ฐ™์•„ Header๋กœ ์„ค์ •ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.
์ž‘์—… ์‹œ ํ˜ผ๋™์ด ์žˆ์„ ์ˆ˜ ์žˆ์„๊ฑฐ ๊ฐ™์€๋ฐ ์–ด๋–ป๊ฒŒ ์ˆ˜์ •ํ•ด์•ผ๋ ์ง€ ์˜๊ฒฌ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค !

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปดํฌ๋„ŒํŠธ ๋งŒ๋“œ์‹œ๋А๋ผ ๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!

๋„ค์ด๋ฐ์˜ ๊ฒฝ์šฐ ํด๋” ๊ตฌ์กฐ์ƒ Header๊ฐ€ ๊ตฌ๋ถ„๋˜์„œ Header๋กœ ์ž‘์—…ํ•˜์…”๋„ ์ƒ๊ด€ ์—†๋‹ค๊ณ  ๊ฐœ์ธ์ ์œผ๋กœ ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.
๋งŒ์•ฝ, ๋„ค์ด๋ฐ์„ ๊ตฌ์ฒด์ ์œผ๋กœ ํ•˜์‹ ๋‹ค๋ฉด ๋ง์”€ํ•ด์ฃผ์‹  ๊ฒƒ์ฒ˜๋Ÿผ ์กฐ๊ธˆ ๊ธธ์–ด์ง€๋”๋ผ๋„ DashboardHeader๊ฐ€ ์ข‹๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค.

์ถ”๊ฐ€ ์ž‘์—…์ด ์žˆ์œผ์‹ค ๊ฒฝ์šฐ PR ํ…œํ”Œ๋ฆฟ์— Additional notes์— todo listํ˜•ํƒœ๋กœ ์ถ”๊ฐ€ํ•ด์ฃผ์‹œ๋ฉด ๋ผ์š”!

์ฐธ๊ณ ๋กœ, gap-[8px], text-[20px] ๋ณด๋‹จ gap-2, text-xl ๋กœํ•˜์‹œ๋Š”๊ฒŒ ์ž‘์—…ํ•˜์‹ค ๋•Œ ๋” ํŽธํ•˜์‹ค๊ฑฐ์—์šฉ

์ง€๋‚œ๋ฒˆ์— ๋งํ–ˆ๋˜ ๊ฒƒ์ฒ˜๋Ÿผ tailwind ํ™•์žฅ ์„ค์น˜ํ•˜์‹œ๋ฉด ์•„๋ž˜ ์‚ฌ์ง„์ฒ˜๋Ÿผ px๋‹จ์œ„๋กœ๋„ vscode๋‚ด์—์„œ ๋ฐ”๋กœ ๋ณผ ์ˆ˜ ์žˆ์–ด์šฉ

image

@SeokChan-Lee SeokChan-Lee merged commit 1ffc8f6 into main Feb 5, 2025
3 checks passed
@SeokChan-Lee SeokChan-Lee added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat : ๋Œ€์‹œ๋ณด๋“œ ํ—ค๋” ๊ณต์šฉ ์ปดํฌ๋„ŒํŠธ ์ž‘์—…

2 participants