Skip to content

Feat/21/button#26

Merged
cksrlcks merged 3 commits intomainfrom
feat/21/button
Feb 5, 2025
Merged

Feat/21/button#26
cksrlcks merged 3 commits intomainfrom
feat/21/button

Conversation

@cksrlcks
Copy link
Collaborator

@cksrlcks cksrlcks commented Feb 5, 2025

โ“์ด์Šˆ

โœ๏ธ Description

๊ณต์šฉ ๋ฒ„ํŠผ ์ปดํฌ๋„ŒํŠธ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค.

  • ํ”ผ๊ทธ๋งˆ ์‹œ์•ˆ์ƒ ์Šคํƒ€์ผ๊ฐ€์ด๋“œ๊ฐ€ ํ†ต์ผ๋˜์–ด์žˆ์ง€ ์•Š์•„์„œ, ์ž์ฒด์ ์œผ๋กœ ์ถ”๋ ธ์Šต๋‹ˆ๋‹ค.
  • ๊ธฐ๋ณธ button props๋ฅผ extends ํ•ฉ๋‹ˆ๋‹ค. (html button props ๊ธฐ๋ณธ์‚ฌ์šฉ๊ฐ€๋Šฅ)
  • cva๋ฅผ ์‚ฌ์šฉ (variant, size ์กฐํ•ฉ)
  • ์‚ฌ์šฉํ•˜๋Š”๊ณณ์—์„œ classname์„ ์ถ”๊ฐ€๋กœ ๋„ฃ์–ด๋„ ์Šคํƒ€์ผ์ด ์ ์šฉ๋  ์ˆ˜ ์žˆ๋„๋ก tailwind merge ์‚ฌ์šฉ

์ถ”๊ฐ€์•ˆ๋‚ด

  • ๊ณต์šฉ ui ์ปดํฌ๋„ŒํŠธ๋ผ๊ณ  ์ƒ๊ฐ๋˜์–ด components/uiํด๋” ๋‚ด๋ถ€์— ๋ฐฐ์น˜ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • clsx, class variance authority, tailwind merge ํŒจํ‚ค์ง€ 3๊ฐœ๊ฐ€ ์ถ”๊ฐ€๋˜์—ˆ์Šต๋‹ˆ๋‹ค. (npm i)
  • util์ชฝ์— cn์ด๋ผ๋Š” helperํ•จ์ˆ˜ ์ž‘์„ฑ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

์ถ”๊ฐ€๋…ผ์˜

  • ๋””์ž์ธ ์‹œ์•ˆ์— ๋ฒ„ํŠผ๋“ค์ด ๋™์ผํ•œ ์œ„์น˜์ธ๊ณณ์ธ๋ฐ๋„ ํ˜•ํƒœ ๋ฐ ๋†’์ด, ํฐํŠธ๋“ฑ์ด ์ œ๊ฐ๊ฐ์ธ ๊ณณ์ด ์žˆ์Šต๋‹ˆ๋‹ค.
  • ์šฐ์„  ์ง€๊ธˆ ์ž‘์„ฑ๋œ variants๋“ค๋กœ๋งŒ ์ž‘์—…ํ•ด์„œ ํ†ต์ผ์„ฑ์„ ์ฃผ๋Š”๊ฒŒ ์ข‹์„๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-02-05 แ„‹แ…ฉแ„Œแ…ฅแ†ซ 11 23 54

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@cksrlcks cksrlcks added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Feb 5, 2025
@cksrlcks cksrlcks requested a review from rak517 February 5, 2025 02:41
@cksrlcks cksrlcks self-assigned this Feb 5, 2025
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 5, 2025 2:41am

Copy link
Collaborator

@rak517 rak517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฃผ์„๋„ ์ž˜ ๋‹ฌ์•„ ์ฃผ์…”์„œ ๊ฐ€์ ธ๋‹ค๊ฐ€ ์‚ฌ์šฉํ•  ๋•Œ ํŽธํ• ๊ฑฐ ๊ฐ™๊ณ  ์ข‹์€๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค!๐Ÿซก

@cksrlcks cksrlcks merged commit 32b51fc into main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat : [๊ณต์šฉ] ๋ฒ„ํŠผ ์ปดํฌ๋„ŒํŠธ ์ž‘์—…

2 participants