Skip to content

Comments

Feat/23/pagination button component#36

Merged
rak517 merged 4 commits intomainfrom
feat/23/pagination-button-component
Feb 5, 2025
Merged

Feat/23/pagination button component#36
rak517 merged 4 commits intomainfrom
feat/23/pagination-button-component

Conversation

@rak517
Copy link
Collaborator

@rak517 rak517 commented Feb 5, 2025

β“μ΄μŠˆ

✍️ Description

Sidebarμ—μ„œ μ‚¬μš©ν•˜λ˜ pagination λ²„νŠΌμ„ μž¬μ‚¬μš©ν•  수 있게 곡용 μ»΄ν¬λ„ŒνŠΈν™” μž‘μ—…

μž‘μ—…μ‚¬ν•­

  • μš°μ„  useChunkPagination 훅을 λ§Œλ“€μ–΄ νŽ˜μ΄μ§€λ„€μ΄μ…˜ 둜직 μž¬μ‚¬μš©ν•  수 μžˆλ„λ‘ 뢄리

  • Sidebar ν΄λ”μ—μžˆλ˜ ArrowLeft, ArrowRigth 톡합 ν›„ pagination ν΄λ”λ‘œ 뢄리

  • SidebarPaginationControlsμ—μ„œ μž¬μ‚¬μš©ν•  수 있게 λ§Œλ“€λ©΄μ„œ PaginationControls 넀이밍 λ‹€μ‹œ ν•˜μ˜€μŠ΅λ‹ˆλ‹€.

  • μ‰½κ²Œ μ‚¬μš©ν•˜κ²Œ λ§Œλ“€μ–΄μ•Ό λ˜λŠ”λ° κ°€μ Έλ‹€κ°€ μ‚¬μš©ν•  λ•Œ λ„ˆλ¬΄ μ–΄λ €μš΄κ±° κ°™μ•„μ„œ μš°μ„  주석 많이 λ‹¬μ•„λ†¨μŠ΅λ‹ˆλ‹€ γ…œ

βœ… Checklist

PR

  • Branch Convention 확인

    feat/* κΈ°λŠ₯ κ΅¬ν˜„, fix/* 버그 μˆ˜μ •, refactor/* κ°œμ„ 

  • Base Branch 확인
  • μ μ ˆν•œ Label μ§€μ •
  • Assignee 및 Reviewer μ§€μ •

Test

  • 둜컬 μž‘λ™ 확인

Additional Notes

  • (μ—†μŒ)

@rak517 rak517 added Priority: Medium πŸ”– μš°μ„ μˆœμœ„ 보톡 Type: Feature ✨ μ‹ κ·œ κΈ°λŠ₯ labels Feb 5, 2025
@rak517 rak517 requested a review from ToKyun02 February 5, 2025 07:44
@rak517 rak517 self-assigned this Feb 5, 2025
@vercel
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
taskify βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Feb 5, 2025 7:44am

Copy link
Owner

@ToKyun02 ToKyun02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νŽ˜μ΄μ§€λ„€μ΄μ…˜μ„ μ»€μŠ€ν…€ hook으둜 λ§Œλ“€μ–΄μ„œ μž¬μ‚¬μš©ν•˜λŠ” 것 μ’‹μŠ΅λ‹ˆλ‹€!

νŽ˜μ΄μ§€λ„€μ΄μ…˜ κΈ°λŠ₯ λ™μž‘λ˜λŠ” 것도 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.

λ‹€λ§Œ, prevλ‚˜ nextκ°€ disableλ˜λŠ” μƒνƒœμ—μ„œ cursor-pointerκ°€ μ•„μ΄μ½˜ μ˜μ—­μ€ default둜 λ³€ν™”λ˜μ§€λ§Œ, μ•„μ΄μ½˜ μ™ΈλΆ€μ˜ λ²„νŠΌ μ˜μ—­μ€ λ³€ν™”λ˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.

μ•„λ§ˆ Arrow μ•„μ΄μ½˜ μͺ½μ—μ„œλ§Œ cursor-pointerκ°€ μ μš©λ˜μ–΄μ„œ 일뢀 μ˜μ—­λ§Œ μ˜λ„ν•˜μ‹ λŒ€λ‘œ λ™μž‘ν•œ 것 κ°™μŠ΅λ‹ˆλ‹€.

저라면 disable에 λ”°λ₯Έ μ»€μ„œ μƒνƒœ 변경은 buttonμ—μ„œλ§Œ μ²˜λ¦¬ν•  것 κ°™μŠ΅λ‹ˆλ‹€.

지엽적인 문제라고 νŒλ‹¨λ˜λ‹ˆ, μš°μ„  μŠΉμΈν•˜κ² μŠ΅λ‹ˆλ‹€!

@rak517 rak517 merged commit e1f229b into main Feb 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium πŸ”– μš°μ„ μˆœμœ„ 보톡 Type: Feature ✨ μ‹ κ·œ κΈ°λŠ₯

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: [곡용] pagination λ²„νŠΌ μ»΄ν¬λ„ŒνŠΈ μž‘μ—…

2 participants