Skip to content

Fix/75/dashboard api #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cksrlcks merged 2 commits into from
Feb 7, 2025
Merged

Fix/75/dashboard api #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fb920f
🐛 Fix : 타입 소문자를 대문자로 변경
cksrlcks Feb 7, 2025
fbd7838
♻️ refactor : dashboard 수정 타입 제거(하나로 통일)
cksrlcks Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/apis/dashboards/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,5 @@
import axiosHelper from '@/utils/network/axiosHelper';
import {
BasePaginationParams,
Dashboard,
DashboardFormType,
DashboardInvitation,
DashboardInvitationResponse,
DashboardsResponse,
GetDashboardsParams,
InviteDashboardType,
updateDashboardType,
} from './types';
import { BasePaginationParams, Dashboard, DashboardFormType, DashboardInvitation, DashboardInvitationResponse, DashboardsResponse, GetDashboardsParams, InviteDashboardType } from './types';

// dashboard 목록 조회
export const getDashboards = async ({ cursorId, page, size, navigationMethod }: GetDashboardsParams) => {
Expand Down Expand Up @@ -37,7 +27,7 @@ export const getDashboardDetails = async (id: number) => {
};

// dashboard 수정
export const updateDashboard = async (id: number, data: updateDashboardType) => {
export const updateDashboard = async (id: number, data: DashboardFormType) => {
const response = await axiosHelper.put<Dashboard>(`/dashboards/${id}`, data);
return response.data;
};
Expand Down
4 changes: 0 additions & 4 deletions src/apis/dashboards/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,6 @@ export const dashboardFormSchema = z.object({
});
export type DashboardFormType = z.infer<typeof dashboardFormSchema>;

// dashboard 수정 스키마
export const updateDashboardFormSchema = dashboardFormSchema.partial();
export type updateDashboardType = Partial<DashboardFormType>;

// invitation 타입
export type InvitationUser = Pick<User, 'id' | 'email' | 'nickname'>;
export type InvitationDashboard = Pick<Dashboard, 'id' | 'title'>;
Expand Down