Skip to content

Refactor/79/change login management#84

Merged
ToKyun02 merged 13 commits intomainfrom
refactor/79/change-login-management
Feb 10, 2025
Merged

Refactor/79/change login management#84
ToKyun02 merged 13 commits intomainfrom
refactor/79/change-login-management

Conversation

@ToKyun02
Copy link
Owner

@ToKyun02 ToKyun02 commented Feb 9, 2025

โ“์ด์Šˆ

โœ๏ธ Description

๋กœ์ปฌ์Šคํ† ๋ฆฌ์ง€์—์„œ ์ฟ ํ‚ค๋กœ ํ† ํฐ ๊ด€๋ฆฌ ๋ฐฉ์‹์„ ๋ณ€๊ฒฝํ•จ์— ๋”ฐ๋ผ ์ˆ˜์ •ํ•œ ๋กœ์ง์— ๊ด€ํ•œ PR์ž…๋‹ˆ๋‹ค.

์ถ”๊ฐ€๋กœ ์™ธ๋ถ€ ๋ฐฑ์—”๋“œ s3 ์ด๋ฏธ์ง€ ๋„๋ฉ”์ธ config์—์„œ ์„ค์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
โ™ป๏ธ refactor : api ์š”์ฒญ catch-all-segment ์ฒ˜๋ฆฌ -> ์ด ์ปค๋ฐ‹ ์ „์—๋Š” ๊ฐ ๋„๋ฉ”์ธ๋ณ„๋กœ route handler๋ฅผ ์„ค์ •ํ–ˆ์—ˆ๋Š”๋ฐ, ๊ทธ๋Ÿด ํ•„์š”๊ฐ€ ์—†๋‹ค๊ณ  ์ƒ๊ฐํ•˜์—ฌ catch-all-segment์˜ route๋กœ ๋กœ์ง ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.

์™ธ๋ถ€ ๋ฐฑ์—”๋“œ API ํ˜ธ์ถœ ํ๋ฆ„์€ ๋‹ค์Œ๊ณผ ๊ฐ™์Šต๋‹ˆ๋‹ค.

  • ์šฐ์„ , ๊ธฐ์กด axios๊ฐ์ฒด์™€ authStore๋Š” ๋‚จ๊ฒจ๋‘๊ณ  ๊ตฌํ˜„ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ธฐ์กด apisํด๋”์— ์ž‘์—…ํ•œ ํŒŒ์ผ์€ /auth, /users๋งŒ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
  1. ํด๋ผ์ด์–ธํŠธ์—์„œ ์ด๋ฒคํŠธ ๋ฐœ์ƒ ์‹œ axiosClientํ˜ธ์ถœ ('/users/me'์ฒ˜๋Ÿผ ์—”๋“œํฌ์ธํŠธ ์„ค์ •)
  2. axiosClient request interceptor์—์„œ '/api'๋ฅผ baseUrl๋กœ ์„ค์ •ํ•˜์—ฌ ('https://origin/api/user/me')๋กœ Next์„œ๋ฒ„์— api ์š”์ฒญ
  3. Next์„œ๋ฒ„์—์„œ axiosServer๊ฐ์ฒด๋กœ ๊ฐ HTTP ์š”์ฒญ์— ๋งž๋Š” ์™ธ๋ถ€ ๋ฐฑ์—”๋“œ API ์š”์ฒญ ์ฒ˜๋ฆฌ(app/api/[...endpoint]/route.ts)
  4. ์™ธ๋ถ€ ๋ฐฑ์—”๋“œ ์š”์ฒญ ์ฒ˜๋ฆฌ ํ›„ ํด๋ผ์ด์–ธํŠธ์—๊ฒŒ ์‘๋‹ต

redirect ๋กœ์ง์€ ๋‹ค์Œ๊ณผ ๊ฐ™์Šต๋‹ˆ๋‹ค.

  • cookie๊ฐ€ ์กด์žฌํ•˜์ง€ ์•Š์Œ
    • ๋กœ๊ทธ์ธ ์ดํ›„ ์ ‘์† ๊ฐ€๋Šฅํ•œ ํŽ˜์ด์ง€์ผ ๊ฒฝ์šฐ /login์œผ๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ
  • cookie๊ฐ€ ์กด์žฌ
    • ๋กœ๊ทธ์ธ ์ด์ „ ์ ‘์† ๊ฐ€๋Šฅํ•œ ํŽ˜์ด์ง€์ผ ๊ฒฝ์šฐ /mydashboard๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ

Link ์ปดํฌ๋„ŒํŠธ๋กœ ์ด๋™ํ•  ๊ฒฝ์šฐ middleware๊ฐ€ ์‹คํ–‰๋˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์—, ํŠน์ • ๋กœ์ง ์ƒ ๋ฌด์กฐ๊ฑด ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ๊ฐ€ ํ•„์š”ํ•  ๊ฒฝ์šฐ Link ํด๋ฆญ์„ button์˜ onClick์ด๋ฒคํŠธ์—์„œ router๋กœ ๊ตฌํ˜„ํ•˜์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

ํŽ˜์ด์ง€์˜ ๋ผ์šฐํŠธ ๊ทธ๋ฃจํ•‘์€ ๋ช…์‹œ์ ์œผ๋กœ ์ผ๋‹จ ํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.(์ž‘์—… ์ถฉ๋Œ ๋ฐฉ์ง€ ๋ชฉ์ )

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • ์ฟ ํ‚ค ์„ค์ • ๋กœ์ง ์žฌ์ถ”๊ฐ€
  • ์ฟ ํ‚ค sameSite lax๋กœ ๋ณ€๊ฒฝ

@ToKyun02 ToKyun02 added Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง labels Feb 9, 2025
@ToKyun02 ToKyun02 self-assigned this Feb 9, 2025
@vercel
Copy link

vercel bot commented Feb 9, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 9, 2025 7:58am

Copy link
Collaborator

@cksrlcks cksrlcks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ์ด์ œ ํด๋ผ์ด์–ธํŠธ์—์„œ๋Š” axiosClientHelper๋กœ ๊ทธ๋ƒฅ ์š”์ฒญ๋ณด๋‚ด๊ธฐ๋งŒํ•˜๋ฉด
์•Œ์•„์„œ ํ† ํฐ๋„ ๋ถ™์—ฌ์„œ ์ง„ํ–‰๋˜๊ฒŒ ํ•˜์‹ ๊ฑฐ๋„ค์š”

http only ์ฟ ํ‚ค์— ์•ˆ์ „ํ•˜๊ฒŒ ์ ‘๊ทผํ•ด์„œ, nextjs์„œ๋ฒ„๊ฐ€ ํด๋ผ์ด์–ธํŠธ ๋Œ€์‹  ๋ฐฑ์•ค๋“œapi์— ์š”์ฒญํ•ด์„œ,
๋‹ค์‹œ ํด๋ผ์ด์–ธํŠธ์—๊ฒŒ ์ „๋‹ฌํ•˜๋Š” ๋ฐฉ์‹ ์ด๋„ค์š”!

์ €๋„ ๋‹ค์Œ์— ์ด๋ ‡๊ฒŒ ํ•œ๋ฒˆ ํ•ด๋ด์•ผ๊ฒ ์Šต๋‹ˆ๋‹น.ใ…Ž

httponly์ฟ ํ‚ค๋กœ ํ•˜์‹ ๋‹ค๊ณ  ํ•˜์…”์„œ, ๋ชจ๋“  api ์š”์ฒญํ•จ์ˆ˜๋ฅผ api routeํ•ธ๋“ค๋Ÿฌ๋กœ ๋งŒ๋“ค์–ด์•ผํ•˜๋‚˜ ๊ฑฑ์ •ํ–ˆ๋Š”๋ฐ ์ด๋Ÿฐ ์ข‹์€ ๋ฐฉ๋ฒ•์ด ์žˆ์—ˆ๋„ค์š”(์ฐธ๊ณ ๋กœ vercel ๋ฌด๋ฃŒ๋ฐฐํฌ์‹œ serverlessํ•จ์ˆ˜๊ฐ€ 12๊ฐœ๋กœ ์ œํ•œ๋˜๋Š”๋ฐ, ์ด๋ ‡๊ฒŒํ•˜๋ฉด ๋นŒ๋“œ์‹œ ํ•œ๊ฐœ๋กœ ๋œจ๋Š”์ง€ ํ•œ๋ฒˆ๋ด์•ผ๊ฒŸ์–ด์šค ใ…‹ใ…‹)

@cksrlcks
Copy link
Collaborator

cksrlcks commented Feb 9, 2025

PR์ด ๋ฉ”์ธ์— ๋จธ์ง€๋˜๊ณ  ๋‚˜๋ฉด, ์ œ๊ฐ€ ์ž‘์„ฑํ–ˆ๋˜ dashboard์ชฝ api ์„œ๋น„์Šค ํ•จ์ˆ˜์— axios helper ๊ต์ฒด๊ฑด์œผ๋กœ prํ•œ๋ฒˆ ๋‹ค์‹œ ์˜ฌ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator

@rak517 rak517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฃผ๋ง์ธ๋ฐ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค! ์ฝ”๋“œ ํ™•์ธํ•ด ๋ดค๋Š”๋ฐ ์ข‹์€ ๋ฐฉ๋ฒ•์ธ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค๐Ÿซก

@ToKyun02 ToKyun02 merged commit fcade91 into main Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low ๐Ÿข ์šฐ์„ ์ˆœ์œ„ ๋‚ฎ์Œ Type: Refactor โ™ป๏ธ ๋ฆฌํŒฉํ† ๋ง

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: ๋กœ๊ทธ์ธ ๋กœ์ง ๋ณ€๊ฒฝ(cookie)

4 participants