Skip to content

Feat/57/password edit#88

Merged
ToKyun02 merged 5 commits intomainfrom
feat/57/password-edit
Feb 10, 2025
Merged

Feat/57/password edit#88
ToKyun02 merged 5 commits intomainfrom
feat/57/password-edit

Conversation

@ToKyun02
Copy link
Owner

โ“์ด์Šˆ

โœ๏ธ Description

๊ธฐ์กด์— ProfileEdit ์ปดํฌ๋„ŒํŠธ๋Š” components/profile/ProfileEdit.tsx๋กœ ์˜ฎ๊ฒจ ๋†จ์Šต๋‹ˆ๋‹ค.

์ž…๋ ฅ ํ•„๋“œ๋Š” ์ฐฌ๊ธฐ๋‹˜์ด ๊ตฌํ˜„ํ•œ ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ ์‚ฌ์šฉํ–ˆ๊ณ , ์ œ์ถœ ๋ฒ„ํŠผ์€ auth ๊ด€๋ จ ํŽ˜์ด์ง€์—์„œ ์ผ๋˜ ๋ฒ„ํŠผ ์žฌ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.

ํ† ํฐ ๋งŒ๋ฃŒ ์‹œ routing ๋กœ์ง๋„ ๊ตฌํ˜„ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.

[์ž‘์—… ๋‚ด์šฉ]

  1. ๋น„๋ฐ€๋ฒˆํ˜ธ ์ˆ˜์ • ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„
  2. /mypage ๋ ˆ์ด์•„์›ƒ ์ž‘์—…
  3. ๋Œ€์‹œ๋ณด๋“œ ๊ด€๋ จ ํŽ˜์ด์ง€ ์ œ์™ธํ•œ ๋ชจ๋“  ํŽ˜์ด์ง€๋“ค ๋ผ์šฐํŒ… ๊ทธ๋ฃน์œผ๋กœ ์ง€์ •(after-login, before-login)

โœ… Checklist

PR

  • Branch Convention ํ™•์ธ

    feat/* ๊ธฐ๋Šฅ ๊ตฌํ˜„, fix/* ๋ฒ„๊ทธ ์ˆ˜์ •, refactor/* ๊ฐœ์„ 

  • Base Branch ํ™•์ธ
  • ์ ์ ˆํ•œ Label ์ง€์ •
  • Assignee ๋ฐ Reviewer ์ง€์ •

Test

  • ๋กœ์ปฌ ์ž‘๋™ ํ™•์ธ

Additional Notes

  • (์—†์Œ)

@ToKyun02 ToKyun02 added Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ labels Feb 10, 2025
@ToKyun02 ToKyun02 requested a review from rak517 February 10, 2025 11:06
@ToKyun02 ToKyun02 self-assigned this Feb 10, 2025
@vercel
Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
taskify โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Feb 10, 2025 11:06am

Copy link
Collaborator

@rak517 rak517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zod ์Šคํ‚ค๋งˆ ์ •์˜ํ•˜๊ณ  zodResolver๋กœ react-hook-form์ด๋ž‘ ์—ฐ๊ฒฐํ•ด์„œ ํผ ์ œ์ถœ ์ „์— ์ž๋™์œผ๋กœ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌํ•ด์ฃผ๋Š”๊ฒŒ ๋งž๋‚˜์šฉ? ๋‚˜์ค‘์— form ์‚ฌ์šฉํ•  ์ผ์ด ์žˆ์œผ๋ฉด ๋กœ์ง๋งŒ ๊ทธ๋Œ€๋กœ ๋”ฐ๋ผํ•ด๋„ ๊ธˆ๋ฐฉ ์™„์„ฑ์ด ๊ฐ€๋Šฅํ•  ์ •๋„๋กœ ์‰ฝ๋„ค์šฉ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!๐Ÿซก

@ToKyun02
Copy link
Owner Author

zod ์Šคํ‚ค๋งˆ ์ •์˜ํ•˜๊ณ  zodResolver๋กœ react-hook-form์ด๋ž‘ ์—ฐ๊ฒฐํ•ด์„œ ํผ ์ œ์ถœ ์ „์— ์ž๋™์œผ๋กœ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌํ•ด์ฃผ๋Š”๊ฒŒ ๋งž๋‚˜์šฉ? ๋‚˜์ค‘์— form ์‚ฌ์šฉํ•  ์ผ์ด ์žˆ์œผ๋ฉด ๋กœ์ง๋งŒ ๊ทธ๋Œ€๋กœ ๋”ฐ๋ผํ•ด๋„ ๊ธˆ๋ฐฉ ์™„์„ฑ์ด ๊ฐ€๋Šฅํ•  ์ •๋„๋กœ ์‰ฝ๋„ค์šฉ ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!๐Ÿซก

zod ์Šคํ‚ค๋งˆ๋กœ ์ž‘์„ฑํ•œ ์œ ํšจ์„ฑ์„ ๋ฆฌ์•กํŠธ ํ›… ํผ๊ณผ ์—ฐ๊ฒฐํ•ด์ฃผ๋Š” ๊ฒƒ์ด zodResolver์ž…๋‹ˆ๋‹น

@ToKyun02 ToKyun02 merged commit d398325 into main Feb 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium ๐Ÿ”– ์šฐ์„ ์ˆœ์œ„ ๋ณดํ†ต Type: Feature โœจ ์‹ ๊ทœ ๊ธฐ๋Šฅ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feat: ๋น„๋ฐ€๋ฒˆํ˜ธ ๋ณ€๊ฒฝ ์ปดํฌ๋„ŒํŠธ

2 participants