Skip to content

Commit

Permalink
Add option to close app after starting the search
Browse files Browse the repository at this point in the history
  • Loading branch information
TobiasBielefeld committed Jun 24, 2024
1 parent 91ced89 commit 6791bba
Show file tree
Hide file tree
Showing 16 changed files with 58 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,13 @@ public class SharedData {
public static String PREF_ORIENTATION;
public static String PREF_STATUS_BAR;
public static String PREF_LANGUAGE;
public static String PREF_CLOSE_AFTER_SEARCH;

public static String DEFAULT_SEARCH_URL;
public static String DEFAULT_ORIENTATION;
public static boolean DEFAULT_STATUS_BAR;
public static boolean DEFAULT_DARK_THEME;
public static boolean DEFAULT_CLOSE_AFTER_SEARCH;
public static int DEFAULT_THEME;
public static int DEFAULT_SEARCH_SELECTED_INDEX;
public static boolean DEFAULT_HIDE_APP_ICON;
Expand Down Expand Up @@ -88,6 +90,7 @@ public static void reinitializeData(Context context){
PREF_THEME = res.getString(R.string.pref_key_theme);
PREF_CUSTOM_SEARCH_URL = res.getString(R.string.pref_key_custom_search_url);
PREF_HIDE_APP_ICON = res.getString(R.string.pref_key_hide_app_icon);
PREF_CLOSE_AFTER_SEARCH = res.getString(R.string.pref_key_close_after_search);

DEFAULT_SEARCH_SELECTED_INDEX = res.getInteger(R.integer.default_search_engine_v2);
DEFAULT_SEARCH_URL = res.getStringArray(R.array.search_engine_uris)[DEFAULT_SEARCH_SELECTED_INDEX];
Expand All @@ -96,6 +99,7 @@ public static void reinitializeData(Context context){
DEFAULT_DARK_THEME = res.getBoolean(R.bool.default_dark_theme);
DEFAULT_THEME = res.getInteger(R.integer.default_theme);
DEFAULT_HIDE_APP_ICON = res.getBoolean(R.bool.default_hide_app_icon);
DEFAULT_CLOSE_AFTER_SEARCH = res.getBoolean(R.bool.default_close_after_search);
}
}

Expand Down Expand Up @@ -132,6 +136,10 @@ public static int getSavedOrientation() {
return Integer.parseInt(getSavedString(PREF_ORIENTATION, "1"));
}

public static boolean getSavedCloseAfterSearch() {
return getSavedBoolean(PREF_CLOSE_AFTER_SEARCH, DEFAULT_CLOSE_AFTER_SEARCH);
}

public static void logText(String text){
Log.e("hey",text);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,10 @@ public void startSearch() {

searchText.setSelection(0, searchText.length()); //select all text to allow for easy delete or modification on resume
records.add(text); //move search term to front of history

if (getSavedCloseAfterSearch()) {
finish();
}
}

/**
Expand Down
3 changes: 2 additions & 1 deletion app/src/main/res/values-de/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@
<string name="settings_change_theme_dark">"Dunkel"</string>
<string name="settings_change_theme_light">"Hell"</string>
<string name="settings_change_theme_default">"System Einstellungen folgen"</string>

<string name="settings_close_after_search_title">App schließen, nachdem die Suche gestartet wurde</string>
<string name="settings_close_after_search_text">Die App wird nicht erneut geöffnet, wenn im Browser auf „Zurück“ geklickt wird.</string>
<!-- About -->
<string name="activity_about">"Über"</string>
<string name="about_description">"Zeige Informationen über die Anwendung wie Lizenzen und Änderungen"</string>
Expand Down
6 changes: 5 additions & 1 deletion app/src/main/res/values-es-rAR/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@
<string name="settings_change_theme_light">Luz</string>

<string name="settings_change_theme_default">Seguir la configuración del sistema</string>


<string name="settings_close_after_search_title">Cerrar la aplicación después de iniciar la búsqueda</string>

<string name="settings_close_after_search_text">La aplicación no se abrirá nuevamente cuando presiones Atrás desde tu navegador</string>

<!--About-->

<string name="activity_about">Acerca de</string>
Expand Down
6 changes: 5 additions & 1 deletion app/src/main/res/values-es/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,11 @@
<string name="settings_change_theme_light">Luz</string>

<string name="settings_change_theme_default">Seguir la configuración del sistema</string>


<string name="settings_close_after_search_title">Cerrar la aplicación después de iniciar la búsqueda</string>

<string name="settings_close_after_search_text">La aplicación no se abrirá nuevamente cuando presiones Atrás desde tu navegador</string>

<!--About-->

<string name="activity_about">Acerca de</string>
Expand Down
4 changes: 3 additions & 1 deletion app/src/main/res/values-fr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,10 @@
<string name="settings_change_theme_dark">Sombre</string>
<string name="settings_change_theme_light">Lumière</string>
<string name="settings_change_theme_default">Suivre les paramètres du système</string>
<string name="settings_close_after_search_title">Fermer l\'application après avoir lancé la recherche</string>
<string name="settings_close_after_search_text">L\'application ne s\'ouvrira pas lorsque vous reviendrez de votre navigateur</string>

<!-- languages -->
<!-- languages -->
<string name="settings_language_default">"Langue par défaut"</string>
<string name="settings_language_english">"Anglais"</string>
<string name="settings_language_french">"Français"</string>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values-it/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@

<string name="about_sliding_tabs_usage">Utilizzato per le schede nella sezione \"Informazioni sul gioco\" schermo</string>

<string name="settings_close_after_search_title">Chiudi l\'app dopo aver avviato la ricerca</string>

<string name="settings_close_after_search_text">L\'app non si aprirà più quando premi Indietro dal browser</string>

<!-- languages -->

<string name="settings_language_default">Lingua di default</string>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values-ja/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@

<string name="about_sliding_tabs_usage">「ゲームについて」画面のタブに使用されます</string>

<string name="settings_close_after_search_title">検索を開始したらアプリを閉じる</string>

<string name="settings_close_after_search_text">ブラウザから戻るを押してもアプリは再び開きません</string>

<!-- languages -->

<string name="settings_language_default">既定の言語</string>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values-tr/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@

<string name="about_sliding_tabs_usage">\"Oyun hakkında\" bölümündeki sekmeler için kullanılır; ekran</string>

<string name="settings_close_after_search_title">Aramayı başlattıktan sonra uygulamayı kapatın</string>

<string name="settings_close_after_search_text">Tarayıcınızdan geri tuşuna bastığınızda uygulama tekrar açılmıyor</string>

<!-- languages -->

<string name="settings_language_default">Varsayılan dil</string>
Expand Down
4 changes: 4 additions & 0 deletions app/src/main/res/values-zh-rCN/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@

<string name="about_sliding_tabs_usage">用于“关于游戏”屏幕中的选项卡</string>

<string name="settings_close_after_search_title">开始搜索后关闭应用程序</string>

<string name="settings_close_after_search_text">当您从浏览器中按“返回”时,应用程序将不会再次打开</string>

<!-- languages -->

<string name="settings_language_default">默认语言</string>
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/bool.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
<bool name="default_status_bar">false</bool>
<bool name="default_dark_theme">false</bool>
<bool name="default_hide_app_icon">false</bool>
<bool name="default_close_after_search">false</bool>
</resources>
1 change: 1 addition & 0 deletions app/src/main/res/values/strings-changelog.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<resources>

<string name="changelog_10_1" translatable="false">Add small delay to showing the keyboard to fix it not showing at all</string>
<string name="changelog_10_2" translatable="false">Add option to close app after starting the search</string>

<string name="changelog_9_1" translatable="false">Use white as app background in light mode again</string>

Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/values/strings-non-translatable.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
<string name="pref_key_hide_status_bar" translatable="false">pref_key_hide_status_bar</string>
<string name="pref_key_custom_search_url" translatable="false">pref_key_custom_search_url</string>
<string name="pref_key_hide_app_icon" translatable="false">pref_key_hide_app_icon</string>
<string name="pref_key_close_after_search" translatable="false">pref_key_close_after_search</string>

<string name="about_app_github_link" translatable="false"><a href="https://github.com/TobiasBielefeld/Simple-Search">GitHub</a></string>
<string name="about_app_license_link" translatable="false"><a href="https://www.gnu.org/licenses/gpl.html">GPL 3.0+</a></string>
Expand Down
3 changes: 3 additions & 0 deletions app/src/main/res/values/strings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@
<string name="settings_change_theme_light">"Light"</string>
<string name="settings_change_theme_default">"Follow system settings"</string>

<string name="settings_close_after_search_title">"Close app after starting search"</string>
<string name="settings_close_after_search_text">"App will not open again when you press back from your browser"</string>

<!--About-->
<string name="activity_about">About</string>
<string name="about_description">Show information about the app like licenses and changelog</string>
Expand Down
8 changes: 8 additions & 0 deletions app/src/main/res/xml/pref_settings.xml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,14 @@
app:entries="@array/pref_search_engine_titles"
app:entryValues="@array/pref_search_engine_values"/>

<SwitchPreferenceCompat
app:iconSpaceReserved="false"
app:singleLineTitle="false"
app:defaultValue="@bool/default_close_after_search"
app:key="@string/pref_key_close_after_search"
app:title="@string/settings_close_after_search_title"
app:summary="@string/settings_close_after_search_text"/>

<SwitchPreferenceCompat
app:iconSpaceReserved="false"
app:singleLineTitle="false"
Expand Down
1 change: 1 addition & 0 deletions metadata/en/changelogs/13.txt
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
* Add small delay to showing the keyboard to fix it not showing at all
* Add option to close app after starting the search

0 comments on commit 6791bba

Please sign in to comment.