Skip to content

font-family property fix in Setting type section #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

font-family property fix in Setting type section #42

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e87d9d
font-family property fix in Setting type section
kakauandme Sep 18, 2017
6d99fe1
font-family property fix in Media queries section
kakauandme Sep 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,20 +162,20 @@ First, provide the typeface variable, and then provide `$fontsize`, `$lineheight
// Heading level 1.
h1 {
// Set font-family
font-family-of($sans);
font-family: font-family-of($sans);
// Set type settings
@include typeset($font: $sans, $fontsize: 38px, $lineheight: 38px, $leader: 2, $trailer: 2rem);
}

// Heading level 2.
h2 {
font-family-of($sans);
font-family: font-family-of($sans);
@include typeset($sans, 26px, 28px, 2, 1);
}

// Paragraph.
p {
font-family-of($sans);
font-family: font-family-of($sans);
@include typeset($sans, 16px, 2rem, 0, 2);
}
```
Expand All @@ -191,7 +191,7 @@ To set type at different breakpoints, our `typeset` mixin needs to know about th

```scss
p {
font-family-of($sans);
font-family: font-family-of($sans);
@include typeset($sans, 16px, 24px, $leader: 0, $trailer: 2);

// we can apply a single breakpoint, starting with breakpoint key: 1
Expand Down