Add core player model tests - #372
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #324
What changed
Replaced the complex-player-model coverage gap with six public-API behavioral tests covering:
PlayerDto→PlayerModel→ DTO round-trippingwaitForReady()resolutionSmartPlayerModelstate projection and typed per-player message routingPlayerStorejoin/update/kick lifecycle with stable model identityThe existing CI workflow already runs
yarn coverage; this PR makes that gate exercise the player abstractions called out by the issue instead of only basic math smoke assertions.Verification
yarn vitest run test/src/player-models.test.ts— 6/6 passingyarn test --run— 5 files / 22 tests passingyarn coverage— 5 files / 22 tests passingPlayerModel.ts: 100% linesSmartPlayerModel.ts: 86.84% linesPlayerStore.ts: 73.5% linessrcand the new test — passingeslint test/src/player-models.test.ts— passingyarn build— passinggit diff --check— passingThe repository's stock
yarn type-checkfails identically on untouchedmasterwith TS6305 becausevite.config.d.tshas not been built from the referencedvite.config.ts. The focused no-reference TypeScript verification above passed.Demo
Screenshots and screencasts are not applicable because this PR adds automated non-visual library coverage only. Run
yarn coverageto reproduce the test and per-file coverage evidence.