Skip to content

Commit

Permalink
Add some downstream tests
Browse files Browse the repository at this point in the history
rapidsai/rapids-dask-dependency#85 changes the
dask dependency to use released versions of Dask. To catch prominant
breakage in downstream libraries (like dask-cudf) with dask main, we'll
add some novel tests here that run downstream (cudf) nightly against
upstream (dask) `main`.
  • Loading branch information
TomAugspurger committed Feb 12, 2025
1 parent 8e3506b commit 2b62e37
Show file tree
Hide file tree
Showing 4 changed files with 25 additions and 1 deletion.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

This repository contains the scripts to run Dask's `gpu`-marked tests on a schedule.

In addition, we run some light downstream tests, as an early warning check for breaking in downstream packages like cuDF, dask-cuDF, and cuML.

## Version Policy

The primary goal here is to quickly identify breakages in tests defined in `dask/dask` and `dask/distributed`, so we'll use the latest `main` from each of those.
Expand Down
14 changes: 14 additions & 0 deletions downstream/test_downstream.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
def test_import_cudf():
import cudf # noqa: F401


def test_import_dask_cudf():
import dask_cudf # noqa: F401


def test_import_cuml():
import cuml # noqa: F401


def test_dask_cuda():
import dask_cuda # noqa: F401
1 change: 1 addition & 0 deletions scripts/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ pip install --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/
"cudf-${RAPIDS_PY_CUDA_SUFFIX}" \
"dask-cudf-${RAPIDS_PY_CUDA_SUFFIX}" \
"ucx-py-${RAPIDS_PY_CUDA_SUFFIX}" \
"cuml-${RAPIDS_PY_CUDA_SUFFIX}" \
"scipy" \
"dask-cuda"

Expand Down
9 changes: 8 additions & 1 deletion scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,14 @@ pytest distributed -v -m gpu --runslow
distributed_status=$?
popd

if [ $dask_status -ne 0 ] || [ $distributed_status -ne 0 ]; then
echo "[testing downstream]"

pushd downstream
pytest -v .
downstream_status=$?
popd

if [ $dask_status -ne 0 ] || [ $distributed_status -ne 0 ] || [ $downstream_status -ne 0 ] ; then
echo "Tests faild"
exit 1
fi

0 comments on commit 2b62e37

Please sign in to comment.