Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Folder 4 for v24.3.0 of CIL #230

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Update Folder 4 for v24.3.0 of CIL #230

merged 5 commits into from
Feb 6, 2025

Conversation

lauramurgatroyd
Copy link
Member

@lauramurgatroyd lauramurgatroyd commented Jan 29, 2025

Changes:

  • finished incomplete sentence
  • change objective_function to f
  • added warnings filter to hide deprecation warnings

@lauramurgatroyd lauramurgatroyd marked this pull request as ready for review January 30, 2025 15:49
@hrobarts
Copy link
Contributor

hrobarts commented Feb 5, 2025

Hi Laura, changes look good to me.
In callbacks

  • Just a note that while testing in a conda environment on reconVM1 these still ran slowly (7 minutes per example) which made me realise maybe we could run a lot fewer iterations for some of these examples without changing the learning outcome. I tried changing the iterations in this PR Switch to astra and reduce CPU use in deep dive demos #207.
  • Typo
    "We seen that over the whole image, the mean squared error initially decreases, but then eventually starts to overfit to the noise in the data. "

    seen -> see

In preconditioner step sizes

  • "Gradient descent with a fixed step size is not guaranteed to converge. As the iterations get near the minimum, a fixed step could cause iterations oscillate around the minimmum but not converge. \n",

    suggest update to "a fixed step could cause iterations to oscillate around the minimum but not converge"

@lauramurgatroyd
Copy link
Member Author

Thanks Hannah, I will take a look at your PR and update the text as you suggested

@lauramurgatroyd
Copy link
Member Author

Lets leave the #207 as a priority for the next online training

Copy link
Contributor

@hrobarts hrobarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Laura, looks good to me

@lauramurgatroyd lauramurgatroyd merged commit c529e18 into main Feb 6, 2025
@lauramurgatroyd lauramurgatroyd deleted the folder4_24.3 branch February 6, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check and update Folder 4 for v24.3.0
2 participants