Skip to content

Refactor manifest validation into isolated script with tests#5

Open
TonkaToyXL wants to merge 1 commit into
mainfrom
refactor-manifest-validation-3207016583253979645
Open

Refactor manifest validation into isolated script with tests#5
TonkaToyXL wants to merge 1 commit into
mainfrom
refactor-manifest-validation-3207016583253979645

Conversation

@TonkaToyXL

Copy link
Copy Markdown
Owner

Refactored inline Python manifest validation logic from scripts/validate.sh into a standalone Python file scripts/manifest_validate.py. Added comprehensive suite of unit tests for this extracted validation logic and updated the GitHub Actions CI workflow to run these tests using pytest.


PR created automatically by Jules for task 3207016583253979645 started by @TonkaToyXL

Extracted inline Python manifest validation logic from `scripts/validate.sh` into `scripts/manifest_validate.py`.
Added robust edge-case tests using `pytest` in `scripts/test_manifest_validate.py`.
Updated the CI workflow to execute `pytest` on the scripts directory prior to executing validation step.

Co-authored-by: TonkaToyXL <83329120+TonkaToyXL@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant