Skip to content

[WIP] compare my branch to master #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

XenoAmess
Copy link
Contributor

No description provided.

@XenoAmess XenoAmess changed the title WIP: compare my branch to master [WIP] compare my branch to master Sep 26, 2022
@XenoAmess XenoAmess force-pushed the master branch 3 times, most recently from 60a24f3 to 3285815 Compare October 3, 2022 09:42
@XenoAmess XenoAmess force-pushed the master branch 10 times, most recently from 8396941 to f58b5d4 Compare March 1, 2023 23:09
@XenoAmess XenoAmess force-pushed the master branch 2 times, most recently from 35f2b20 to ff8690a Compare March 18, 2023 23:03
Copy link
Contributor

@mschultheiss83 mschultheiss83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions, and why did you put ts code in here?

} catch (e) {
global.friends = [];
}
global.friends = ["Antagonist", "ceneezer"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@@ -46,8 +42,8 @@ global.config = {

info: {
signController: true,
signText: 'Fully automated open source NPC: http://tooangel.github.io/screeps/',
resignInterval: 500,
signText: 'XenoAmesss here. Nice to meat you!',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@@ -220,7 +216,7 @@ global.config = {

myRoom: {
underAttackMinAttackTimer: 50,
leastSpawnsToRebuildStructureSpawn: 1,
leastSpawnsToRebuildStructureSpawn: 2,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a good idea in hostile env.

@@ -106,6 +109,8 @@ Room.prototype.spawnCheckForCreate = function() {
creep.ttl = creep.ttl || config.creep.queueTtl;
if (this.findSpawnsNotSpawning().length === 0) {
creep.ttl--;
} else if (this.energyAvailable === this.energyCapacityAvailable) {
creep.ttl = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why

@@ -416,8 +416,7 @@ roles.carry.action = function(creep) {
// End of path, can't harvest, suicide (otherwise the sourcer gets stuck)
if (!reverse && creep.body.filter((part) => part.type === WORK).length === 0) {
// creep.log('Suiciding because end of path, no energy, do not want to get in the way of the sourcer (better recycle?)');
creep.memory.killed = true;
creep.suicide();
creep.moveRandom();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thats not a good idea? why don't they have a plan where from where to go

@@ -118,7 +118,7 @@ function harvest(creep) {
if (returnCode === ERR_NO_BODYPART) {
creep.room.checkRoleToSpawn('defender', 2, undefined, creep.room.name);
creep.respawnMe();
creep.suicide();
creep.memory.role = 'scout';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this thing is dying, why make it to scout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants