Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Commit

Permalink
rename nameFromUrl to schemeFromUrl
Browse files Browse the repository at this point in the history
  • Loading branch information
mattes committed Feb 10, 2017
1 parent 46c16bb commit 8ba71b0
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 9 deletions.
8 changes: 4 additions & 4 deletions migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ type Migrate struct {
func New(sourceUrl, databaseUrl string) (*Migrate, error) {
m := newCommon()

sourceName, err := nameFromUrl(sourceUrl)
sourceName, err := schemeFromUrl(sourceUrl)
if err != nil {
return nil, err
}
m.sourceName = sourceName

databaseName, err := nameFromUrl(databaseUrl)
databaseName, err := schemeFromUrl(databaseUrl)
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -100,7 +100,7 @@ func New(sourceUrl, databaseUrl string) (*Migrate, error) {
func NewWithDatabaseInstance(sourceUrl string, databaseName string, databaseInstance database.Driver) (*Migrate, error) {
m := newCommon()

sourceName, err := nameFromUrl(sourceUrl)
sourceName, err := schemeFromUrl(sourceUrl)
if err != nil {
return nil, err
}
Expand All @@ -126,7 +126,7 @@ func NewWithDatabaseInstance(sourceUrl string, databaseName string, databaseInst
func NewWithSourceInstance(sourceName string, sourceInstance source.Driver, databaseUrl string) (*Migrate, error) {
m := newCommon()

databaseName, err := nameFromUrl(databaseUrl)
databaseName, err := schemeFromUrl(databaseUrl)
if err != nil {
return nil, err
}
Expand Down
11 changes: 6 additions & 5 deletions util.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ func suint(n int) uint {
return uint(n)
}

// newSlowReader turns an io.Reader into a slow io.Reader
// use to simulate a slow internet connection
// newSlowReader turns an io.ReadCloser into a slow io.ReadCloser.
// Use this to simulate a slow internet connection.
func newSlowReader(r io.ReadCloser) io.ReadCloser {
return &slowReader{
rx: r,
Expand Down Expand Up @@ -75,16 +75,17 @@ func (b *slowReader) Close() error {
return b.rx.Close()
}

var errNoName = fmt.Errorf("no name")
var errNoScheme = fmt.Errorf("no scheme")

func nameFromUrl(url string) (string, error) {
// schemeFromUrl returns the scheme from a URL string
func schemeFromUrl(url string) (string, error) {
u, err := nurl.Parse(url)
if err != nil {
return "", err
}

if len(u.Scheme) == 0 {
return "", errNoName
return "", errNoScheme
}

return u.Scheme, nil
Expand Down

0 comments on commit 8ba71b0

Please sign in to comment.