-
-
Notifications
You must be signed in to change notification settings - Fork 9
feat: adapt code and playgrounds to latest changes on ecosystem #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alvarosabu
wants to merge
6
commits into
main
Choose a base branch
from
feat/adapt-to-core-v5-changes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,570
−2,593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alvarosabu
commented
Jun 15, 2025
- Updated @tresjs/cientos and @tresjs/core to version 5.0.0-next.2 and 5.0.0-next.3 respectively in package.json and pnpm-lock.yaml.
- Refactored GLTF model loading in BlenderCube.vue and Ducky.vue to use state instead of scene for better reactivity.
- Removed unnecessary Suspense components in DepthOfFieldDemo.vue and DotScreenDemo.vue for improved performance.
- Updated ESLint auto-imports and components.d.ts for better type support.
- Cleaned up unused package.json file in playground/public/nuxt-stones.
- Updated @Tresjs/cientos and @Tresjs/core to version 5.0.0-next.2 and 5.0.0-next.3 respectively in package.json and pnpm-lock.yaml. - Refactored GLTF model loading in BlenderCube.vue and Ducky.vue to use state instead of scene for better reactivity. - Removed unnecessary Suspense components in DepthOfFieldDemo.vue and DotScreenDemo.vue for improved performance. - Updated ESLint auto-imports and components.d.ts for better type support. - Cleaned up unused package.json file in playground/public/nuxt-stones.
- Cleaned up the imports in BlenderCube.vue by removing the unused watchEffect import, improving code clarity and maintainability.
commit: |
- Upgraded @Tresjs/core in package.json and playground/package.json to version 5.0.0-next.5 for improved functionality and compatibility. - Updated pnpm-lock.yaml to reflect the new version of @Tresjs/core and its dependencies. - Refactored render logic in EffectComposerPmndrs.vue and EffectComposer.vue to utilize notifySuccess callback for better rendering control.
Tinoooo
requested changes
Jun 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided an MR that addresses the comments I made.
* refactor: streamline rendering logic in effect processors * chore: update dependencies and improve rendering logic in on-demand playground example
Tinoooo
reviewed
Jun 22, 2025
Tinoooo
approved these changes
Jun 22, 2025
- Eliminated the onControlChange function as it was no longer necessary, simplifying the component's logic. - Updated OrbitControls to remove the change event listener, streamlining the rendering process.
- Upgraded @Tresjs/core in package.json and playground/package.json to version 5.0.0-next.6 for enhanced features and stability. - Updated pnpm-lock.yaml to reflect the new version and its dependencies, ensuring compatibility across the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.