feat: custom sharePath setting #1781
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1st time using Meld. I'm not sure if the conflict resolve is clean
commented out for now, to make sure we get back to it – not sure if it was suppossed to have any special other reason to exist
caused by having other several save operation inside the save() method (which doesn't even make sense to begin with, as far as I can tell) moving it to inside the "change" event handler allows us to set and store a custom share path again
there's no need to execute PUT requests for *all* Share Settings, when any option changes moved the code to inside the "change" event handlers
…rectBareDomain change → that is what the shareRootCheck button is there for
…g new local $button variable
* add rudimental error handling * add handling of special case, where one has multiple shared notes with a #shareRoot label * refactor styling into auxiliary setCheckShareRootStyle function
* add normalization helper to ensure string does not start with multiple trailing slashes or ends with a trailing slash * fall back to default "/share" when empty string is entered
it currently fails trying to import the class though a "manual" importing of the function did pass all checks though -> will need to investigate why importing the class does not work like that
that should be part of a later PR
normalization is happening in the share settings options widget in the meantime, making it more obvious to the user
that should be part of a later PR
needs to currently mention, that a server restart is required
…working this will be handled by cleanUrl PR later on
that should be part of a later PR
|
|
|
update: I will hopefully be able to spend some time this weekend to fix merge conflicts and do some final testing here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
this is a continuation/rework of @maphew's PR #1288
thanks for his initial work!
I did remove anything "cleanUrl" related from this PR for now, to make first feature work
We can look into working on adding the "cleanUrl" approach again, after this PR, as
Feel free to test — note: in order for the path change to take effect, you need to restart the server, not only the frontend.
This is something that can potentially be improved in the future.
also note: this is still in draft due to:
so the PR is only here so that people can already test this, if they want to. Ideally -> don't merge yet :-)
please note: I will be OOO till May 5th, so don't expect any answers to any questions before then :-)