feat: support custom oidc server #1815
Draft
+46
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pano9000
reviewed
May 4, 2025
There was a problem hiding this comment.
IMHO the added config names should be prefixed with a more descriptive prefix, because reading e.g. TRILIUM_ISSUER_NAME is not really telling me what that is.
Something like TRILIUM_OPENID_ISSUER_NAME or TRILIUM_OIDC_ISSUER_NAME is a lot more clear.
(correct me if my terminology is wrong here though, not a huge expert on OAUTH vs OpenID and how all that is intertwined).
it would also be more "inline" with the other config naming
what do you think?
pano9000
reviewed
May 4, 2025
There was a problem hiding this comment.
regarding the naming -> see comment below as well please :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows setting a custom OIDC server.
Three fields have been added to
MultiFactorAuthentication:issuerBaseUrl: Set the base URL for the OpenID Connect issuer.issuerName: Set the name of the OpenID Connect issuer.issuerIcon: Set the URL of the icon for the OpenID Connect issuer.This has been tested with
Authelia, and if the fields are left empty, it defaults to Google OIDC.