fix(client): show warning/error when app is using Rosetta 2 translation (running wrong arch) #2281
Conversation
dosubot
bot
added
the
size:L
perfectra1n
changed the title
| this.$widget.find(".rosetta-warning-recommendation").text(t("rosetta_warning.recommendation")); | ||
| this.$widget.find(".rosetta-warning-download-link").text(t("rosetta_warning.download_link")); | ||
| this.$widget.find(".rosetta-warning-continue-anyway").text(t("rosetta_warning.continue_anyway")); | ||
| this.$widget.find(".rosetta-warning-dont-show-again").text(t("rosetta_warning.dont_show_again")); |
There was a problem hiding this comment.
Does this checkbox do anything?
There was a problem hiding this comment.
To not show the warning again?
| import { t } from "../../services/i18n.js"; | ||
|
|
||
| const TPL = /*html*/` | ||
| <div class="rosetta-warning-dialog modal mx-auto" tabindex="-1" role="dialog" style="z-index: 2000;"> |
There was a problem hiding this comment.
Under dark mode, the contrast for the title is not great. I suggest we remove the red background.
…t lol" This reverts commit e401c8c.
|
This, to me, looks like a lot of code for not much gain (it is platform-specific and time-bound, considering that rosetta2 is going to be phased-out very soon. Is there a way we could annotate this code for removal, so we don't carry it needlessly into the future as a debt? |
It’ll be completely phased out in 2029 (official support), and users will still be able to use Rosetta 2 compatible Macs for even longer after (since they won’t be on the latest MacOS anymore), so I’d say it won’t be going away anytime soon. and thankfully with GitHub and git, we can just reference this PR and remove the code! 😄 |
I mean, it's probably good code hygiene to mark this type of code in a specific manner (using PR labels, or code annotations/comments, or whatever… suggestions welcome!) so it's not eventually forgotten about. I'm not making the case that it is impossible for a superhuman with git chops and a complete memory of the code and its full history not to forget about it, I'm making the case that it should be easy for future contributors (and/or our busy future selves) to periodically review those annotated bits for retention or removal. |
|
@rom1dep , the feature was added as a real need since it seems some people are running on the wrong arch. Please note it's not only for macOS, but also for Windows on ARM. |
yup, saw that you enhanced the PR and made it immensely more generic, thanks for that! The point still stands, I suppose, about annotating this type of code for future removal. |
No description provided.