Open
Conversation
LuminousLlama
commented
Sep 17, 2025
Comment on lines
31
to
34
| DeclareLaunchArgument( | ||
| "cpu_sim", | ||
| default_value="false", | ||
| default_value="true", | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
this will make this parameter true for everybody. You can change the default values for ur specific development process but dont commit them
LuminousLlama
commented
Sep 17, 2025
Comment on lines
81
to
88
| DeclareLaunchArgument( | ||
| "primary_color", | ||
| default_value="blue", | ||
| ), | ||
| DeclareLaunchArgument( | ||
| "secondary_color", | ||
| default_value="blue", | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
i think it would be a good idea to rename it to smth like primary_robot_color
LuminousLlama
commented
Sep 17, 2025
Comment on lines
82
to
90
| for part in shape.parts: | ||
| part.material.set_base_color([0, 0, 1, 1]) | ||
| part.material.set_emission([0, 0, 100, 100]) | ||
| if "color" in self.options: | ||
| if self.options["color"] == "blue": | ||
| part.material.set_base_color([0, 0, 1, 1]) | ||
| part.material.set_emission([0, 0, 100, 100]) | ||
| elif self.options["color"] == "red": | ||
| part.material.set_base_color([1, 0, 0, 1]) | ||
| part.material.set_emission([100, 0, 0, 100]) | ||
| part.material.set_emission_texture(None) |
Contributor
Author
There was a problem hiding this comment.
Instead of a string lets make the "robot color" ros parameter a 4 long array of floats. That way we can also parameterize the rgba values instead of hard coding them
LuminousLlama
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.