Report retry count on Ok results
#235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konstin
added a commit
to astral-sh/uv
that referenced
this pull request
Jun 16, 2025
Using a companion change in the middleware (TrueLayer/reqwest-middleware#235, forked&tagged pending review), we can check and show retries for HTTP status core errors, to consistently report retries again. We fix two cases: * Show retries for status code errors for cache client requests * Show retries for status code errors for Python download requests Not handled: * Show previous retries when a distribution download fails mid-streaming * Perform retries when a distribution download fails mid-streaming * Show previous retries when a Python download fails mid-streaming * Perform retries when a Python download fails mid-streaming
Report retry count on `Ok` results that underwent retries through a `RetryCount` response extension, so that users can include the retry count in error messages. We discovered in uv that we were not reporting retries for status code errors. This change does for `Ok` results what TrueLayer#159 did for `Err` results.
konstin
force-pushed
the
konsti/report-retry-counts
branch
from
ad8b9d3 to
7a36fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report retry count on
Okresults that underwent retries through aRetryCountresponse extension, so that users can include the retry count in error messages.We discovered in uv that we were not reporting retries for status code errors. This change does for
Okresults what #159 did forErrresults, enabling consistently showing retry messages in error traces (astral-sh/uv#13897).