Eliminate any types from API layer#229
Open
DevRushd wants to merge 1 commit into
Open
Conversation
Define typed raw response interfaces (RawInvoiceResponse, RawPoolStatsResponse, RawLPPositionResponse, RawEventLogResponse) to replace all any usages in parse functions and apiFetch calls. Closes TrusTrove#210
Contributor
|
@DevRushd is attempting to deploy a commit to the K1NGD4VID Team on Vercel. A member of the Team first needs to authorize it. |
|
@DevRushd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
resolve Conflict @DevRushd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defines typed raw response interfaces to replace all
anyusages inapps/web/lib/api.ts, eliminating TypeScript type-safety holes in the API layer.Changes
RawInvoiceResponse,RawPoolStatsResponse,RawLPPositionResponse,RawEventLogResponse— model the exact snake_case shapes returned by the indexer APIraw: anyparameters replaced with the correspondingRaw*interfaceapiFetch<any>calls replaced withapiFetch<Raw*Response>data: any[]replaced withdata: RawInvoiceResponse[]in the inline paginated response typeImpact
anytypes remain inapps/web/lib/api.tsAcceptance criteria
anytypes used inlib/api.tstsc --noEmit— only pre-existing errors remain)Closes #210