security(registry): add max batch size limit to batch_register_issuers (#132)#150
Closed
Micheal-Blessed wants to merge 2 commits into
Closed
security(registry): add max batch size limit to batch_register_issuers (#132)#150Micheal-Blessed wants to merge 2 commits into
Micheal-Blessed wants to merge 2 commits into
Conversation
TrusTrove#132) Define MAX_BATCH_SIZE = 100 and panic with BatchTooLarge error when the input vector exceeds this limit to prevent gas exhaustion and DoS attacks from oversized batch registration. Changes: - errors.rs: add BatchTooLarge = 5 variant to RegistryError - lib.rs: add MAX_BATCH_SIZE constant and early length check - test.rs: add test_batch_register_issuers_exceeds_max_panics - Delete stale test snapshots (regenerated on next test run) Closes TrusTrove#132
Resolved conflicts: - errors.rs: adopt BatchSizeExceeded naming from upstream - lib.rs: batch size 50 with BatchSizeExceeded error, keep MAX_BATCH_SIZE constant - Snapshots: accept upstream versions
|
@Micheal-Blessed Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Author
|
@K1NGD4VID please review and merge |
Contributor
|
Resolve Merge Conflict @Micheal-Blessed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enforce MAX_BATCH_SIZE=100 on batch_register_issuers to prevent gas exhaustion and DoS.
Changes
Closes #132