fix(invoice): safely handle XDR encoding in invoice ID generation - #163
Closed
Aycode01 wants to merge 5 commits into
Closed
fix(invoice): safely handle XDR encoding in invoice ID generation#163Aycode01 wants to merge 5 commits into
Aycode01 wants to merge 5 commits into
Conversation
|
@Aycode01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Aycode01
force-pushed
the
fix/safe-invoice-id-xdr
branch
from
June 30, 2026 09:22
ccfb464 to
1854606
Compare
Aycode01
force-pushed
the
fix/safe-invoice-id-xdr
branch
from
June 30, 2026 10:12
15b8df8 to
5b66119
Compare
Contributor
Author
|
review and merge |
Aycode01
changed the title
Contributor
|
resolve Merge Conflict @Aycode01 |
Contributor
|
fix ci error @Aycode01 |
Contributor
|
Still failing Ci Error @Aycode01 |
Contributor
Author
|
Boss the day I resolved this issue and told u to merge this it doesn’t have
any ci error which mean it came up after and I’m not with my laptop to do
anything today
…On Wed, 8 Jul 2026 at 08:48, Adesanya Fuhad ***@***.***> wrote:
*K1NGD4VID* left a comment (TrusTrove/TrusTrove-contract#163)
<#163 (comment)>
Still failing Ci Error @Aycode01 <https://github.com/Aycode01>
—
Reply to this email directly, view it on GitHub
<#163?email_source=notifications&email_token=BCYBWMHCQTYJZA6D4V5OTLD5DX4GVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJRGI2TKNBYGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4912554842>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCYBWMFI57E7TQJ2GLTDJXL5DX4GVAVCNFSNUABGKJSXA33TNF2G64TZHMYTENRVGEYTENZXG45US43TOVSTWNBXG42TENBWHAZDBILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/BCYBWMHH3KACJIYDOCU4ASL5DX4GVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJRGI2TKNBYGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/BCYBWME2TW4PCQKFOKRM7OT5DX4GVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOJRGI2TKNBYGQZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates invoice ID generation to safely handle XDR-encoded addresses of varying lengths, removing unsafe indexing that could cause panics while preserving deterministic and unique invoice IDs.
Closes #131
Type of Change
Changes Made
Testing Done
cargo testsuccessfully