fix(pool): decrement LPInitialDeposit on withdrawal and add multi-wit…#35
Merged
Conversation
|
@Ce-Royals Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
@Ce-Royals fix ci error |
Ce-Royals
force-pushed
the
LPInitialDeposit
branch
from
6865099 to
4e9cc77
Compare
Contributor
|
Fix Ci Error @Ce-Royals |
Ce-Royals
force-pushed
the
LPInitialDeposit
branch
from
206361e to
5924398
Compare
- Remove trusttrove_common dependency and persistent_set usage - Add extend_instance_ttl calls across all contracts - Escrow: enforce full repayment only, add handle_default with caller auth - Invoice: remove supported assets feature, emit pool/expiry events - Pool: remove checked math, update LPInitialDeposit tracking - Update test snapshots to match new contract behavior
Ce-Royals
force-pushed
the
LPInitialDeposit
branch
from
5924398 to
20f6b2b
Compare
Contributor
|
Please resolve Merge Conflict @Ce-Royals |
Ce-Royals
force-pushed
the
LPInitialDeposit
branch
from
bcbd38d to
db4cec1
Compare
Ce-Royals
force-pushed
the
LPInitialDeposit
branch
from
db4cec1 to
fb9fe58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #19
Summary
Fixes an LP withdrawal accounting bug where LPInitialDeposit was not decremented after partial withdrawals. This caused repeated withdrawals to overstate principal, underreport yield, and leave stale initial deposit storage.
What changed
lib.rs
test.rs
Why it matters
Without this fix, repeated partial withdrawals used stale initial deposit values for principal calculations, causing: