Skip to content

🐛 Fixed silent importer failures and non-error rejections #27651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
envsecure wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🐛 Fixed silent importer failures and non-error rejections #27651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
03d1313
🐛 Fixed non-error rejection in DataImporter
envsecure May 2, 2026
143bd65
✨ Included error message in import completion email
envsecure May 2, 2026
e641460
♻️ Restored original HTML structure to email template and included er…
envsecure May 2, 2026
9840570
🛡️ Hardened error handling in email template
envsecure May 2, 2026
0873fb9
fix: add HTML sanitization and robust error handling to email template
envsecure May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
177 changes: 17 additions & 160 deletions ghost/core/core/server/data/importer/email-template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,163 +1,20 @@
module.exports = ({result, siteUrl, postsUrl, emailRecipient}) => `
<!doctype html>
<html>
<head>
<meta name="viewport" content="width=device-width">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>Your content import is complete</title>
<style>
/* -------------------------------------
RESPONSIVE AND MOBILE FRIENDLY STYLES
------------------------------------- */
@media only screen and (max-width: 620px) {
table[class=body] h1 {
font-size: 28px !important;
margin-bottom: 10px !important;
}
table[class=body] p,
table[class=body] ul,
table[class=body] ol,
table[class=body] td,
table[class=body] span,
table[class=body] a {
font-size: 16px !important;
}
table[class=body] .title {
font-size: 22px !important;
}
table[class=body] .wrapper,
table[class=body] .article {
padding: 10px !important;
}
table[class=body] .content {
padding: 0 !important;
}
table[class=body] .container {
padding: 0 !important;
width: 100% !important;
}
table[class=body] .main {
border-left-width: 0 !important;
border-radius: 0 !important;
border-right-width: 0 !important;
}
table[class=body] .btn table {
width: 100% !important;
}
table[class=body] .btn a {
width: 100% !important;
}
table[class=body] .img-responsive {
height: auto !important;
max-width: 100% !important;
width: auto !important;
}
table[class=body] p[class=small],
table[class=body] a[class=small] {
font-size: 12x !important;
}
${(() => {
const escapeHtml = (unsafe) => (unsafe || '').toString()
.replace(/&/g, '&amp;')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#039;');
const errors = result?.data?.errors;
const hasErrors = errors && Array.isArray(errors) && errors.length > 0;
if (hasErrors) {
const msg = errors[0].message || errors[0].toString() || 'Unknown error';
return `Import unsuccessful: ${escapeHtml(msg)}`;
}
/* -------------------------------------
PRESERVE THESE STYLES IN THE HEAD
------------------------------------- */
@media all {
.ExternalClass {
width: 100%;
}
.ExternalClass,
.ExternalClass p,
.ExternalClass span,
.ExternalClass font,
.ExternalClass td,
.ExternalClass div {
line-height: 100%;
}
.recipient-link a {
color: inherit !important;
font-family: inherit !important;
font-size: inherit !important;
font-weight: inherit !important;
line-height: inherit !important;
text-decoration: none !important;
}
#MessageViewBody a {
color: inherit;
text-decoration: none;
font-size: inherit;
font-family: inherit;
font-weight: inherit;
line-height: inherit;
}
}
hr {
border-width: 0;
height: 0;
margin-top: 34px;
margin-bottom: 34px;
border-bottom-width: 1px;
border-bottom-color: #EEF5F8;
}
a {
color: #3A464C;
}
</style>
</head>
<body class="" style="background-color: #ffffff; font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; -webkit-font-smoothing: antialiased; font-size: 14px; line-height: 1.5em; margin: 0; padding: 0; -ms-text-size-adjust: 100%; -webkit-text-size-adjust: 100%;">
<table border="0" cellpadding="0" cellspacing="0" class="body" style="border-collapse: separate; mso-table-lspace: 0pt; mso-table-rspace: 0pt; width: 100%;">
<tr>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top;">&nbsp;</td>
<td class="container" style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top; display: block; Margin: 0 auto; max-width: 540px; padding: 10px; width: 540px;">
<div class="content" style="box-sizing: border-box; display: block; Margin: 0 auto; max-width: 600px; padding: 30px 20px;">

<!-- START CENTERED CONTAINER -->
<span class="preheader" style="color: transparent; display: none; height: 0; max-height: 0; max-width: 0; opacity: 0; overflow: hidden; mso-hide: all; visibility: hidden; width: 0;">Your content import is complete</span>
<table class="main" style="border-collapse: separate; mso-table-lspace: 0pt; mso-table-rspace: 0pt; width: 100%; background: #ffffff; border-radius: 8px;">

<!-- START MAIN CONTENT AREA -->
<tr>
<td class="wrapper" style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top; box-sizing: border-box;">
<table border="0" cellpadding="0" cellspacing="0" style="border-collapse: separate; mso-table-lspace: 0pt; mso-table-rspace: 0pt; width: 100%;">
<tr>
<td align="center" style="padding-top: 20px; padding-bottom: 12px;"><img src="https://static.ghost.org/v4.0.0/images/ghost-orb-4.png" width="60" height="60" style="width: 60px; height: 60px;" /></td>
</tr>
<tr>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 16px; vertical-align: top;">
<p class="title" style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 21px; color: #3A464C; font-weight: normal; line-height: 25px; margin-bottom: 30px; margin-top: 50px; font-weight: 600; color: #15212A;">${result?.data?.errors ? 'Import unsuccessful' : 'Your content import has finished successfully'}</p>
</td>
</tr>
${result?.data?.errors ? `
<tr>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top; padding-bottom: 16px;">One or more error occured while importing your content. Please contact support or report on the <a href="https://forum.ghost.org/">Ghost Community Forum</a>.</td>
</tr>
` : `
<tr>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top; padding-bottom: 12px; padding-top: 16px;">
<a href="${postsUrl.href}" target="_blank" style="display: inline-block; color: #ffffff; background-color: #15212A; border: solid 1px #15212A; border-radius: 5px; box-sizing: border-box; cursor: pointer; text-decoration: none; font-size: 16px; font-weight: normal; margin: 0; padding: 9px 22px 10px; border-color: #15212A;">View posts</a>
</td>
</tr>
`}
</table>
</td>
</tr>
<tr>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; vertical-align: top; padding-top: 80px; padding-bottom: 10px;">
<div class="footer">
<p class="small" style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; color: #738A94; font-weight: normal; margin: 0; line-height: 18px; margin-bottom: 0px; font-size: 11px;">This email was sent from <a href="${siteUrl.href}" style="color: #738A94;">${siteUrl.host}</a> to <a href="mailto:${emailRecipient}" style="color: #738A94;">${emailRecipient}</a></p>
</div>
</td>
</tr>

<!-- END MAIN CONTENT AREA -->
</table>

return 'Your content import has finished successfully';
})()}

<!-- END CENTERED CONTAINER -->
</div>
</td>
<td style="font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', Roboto, Helvetica, Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol'; font-size: 14px; vertical-align: top;">&nbsp;</td>
</tr>
</table>
</body>
</html>
`;
[Ghost Community Forum](https://forum.ghost.org/)
[View posts](${postsUrl.href})

This email was sent from [${siteUrl.host}](${siteUrl.href}) to [${emailRecipient}](mailto:${emailRecipient})
Comment on lines +1 to +20
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether the file currently has the required JS/template wrapper
FILE="ghost/core/core/server/data/importer/email-template.js"

echo "=== File content with line numbers ==="
nl -ba "$FILE" | sed -n '1,240p'

echo
echo "=== Check for expected wrapper constructs ==="
rg -n "module\\.exports\\s*=|tpl`|`;" "$FILE"

echo
echo "=== Quick parse-risk indicators ==="
rg -n "^\\$\\{\\(\\(" "$FILE"
rg -n "^\\[Ghost Community Forum\\]|^\\[View posts\\]|^This email was sent" "$FILE"

Repository: TryGhost/Ghost

Length of output: 579

🏁 Script executed:

cat "ghost/core/core/server/data/importer/email-template.js"

Repository: TryGhost/Ghost

Length of output: 833

File is syntactically invalid—missing module.exports and template literal wrapper.

The file currently contains only a template expression and markdown strings without any surrounding module wrapper. Lines 1–20 cannot execute as valid JavaScript. The entire content must be wrapped with module.exports = ({result, siteUrl, postsUrl, emailRecipient}) => tpl\`` at the start and `` ; `` at the end to function.

Proposed fix 
+const tpl = require('@tryghost/tpl');
+
+module.exports = ({result, siteUrl, postsUrl, emailRecipient}) => tpl`
 ${(() => {
     const escapeHtml = (unsafe) => (unsafe || '').toString()
         .replace(/&/g, '&amp;')
         .replace(/</g, '&lt;')
         .replace(/>/g, '&gt;')
         .replace(/"/g, '&quot;')
         .replace(/'/g, '&#039;');
     const errors = result?.data?.errors;
     const hasErrors = errors && Array.isArray(errors) && errors.length > 0;
     if (hasErrors) {
         const msg = errors[0].message || errors[0].toString() || 'Unknown error';
         return `Import unsuccessful: ${escapeHtml(msg)}`;
     }
     return 'Your content import has finished successfully';
 })()}
 
 [Ghost Community Forum](https://forum.ghost.org/)
 [View posts](${postsUrl.href})
 
 This email was sent from [${siteUrl.host}](${siteUrl.href}) to [${emailRecipient}](mailto:${emailRecipient})
+`;
🧰 Tools
🪛 Biome (2.4.14)

[error] 1-1: Expected a semicolon or an implicit semicolon after a statement, but found none

(parse)

[error] 17-17: expected , but instead found Community

(parse)

[error] 17-17: expected , but instead found Forum

(parse)

[error] 17-17: expected , but instead found :

(parse)

[error] 18-18: expected , but instead found [

(parse)

[error] 18-18: expected , but instead found posts

(parse)

[error] 18-18: expected , but instead found {

(parse)

[error] 18-18: expected , but instead found .

(parse)

[error] 20-20: expected , but instead found This

(parse)

[error] 20-20: expected , but instead found email

(parse)

[error] 20-20: expected , but instead found was

(parse)

[error] 20-20: expected , but instead found sent

(parse)

[error] 20-20: expected , but instead found from

(parse)

[error] 20-20: expected ] but instead found {

(parse)

[error] 20-20: expected , but instead found .

(parse)

[error] 20-20: expected , but instead found ]

(parse)

[error] 20-20: Expected a statement but instead found ') to [$'.

(parse)

[error] 20-20: Expected a statement but instead found '](mailto:$'.

(parse)

[error] 20-20: Expected a statement but instead found ')'.

(parse)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ghost/core/core/server/data/importer/email-template.js` around lines 1 - 20,
The file is missing the module export wrapper and template literal; wrap the
existing template content in a function export like module.exports = ({result,
siteUrl, postsUrl, emailRecipient}) => tpl`...`; ensure the opening line
contains that exact signature and the file ends with the closing backtick and
semicolon, so the existing escapeHtml logic and uses of result, siteUrl,
postsUrl, and emailRecipient live inside the returned template literal.

3 changes: 2 additions & 1 deletion ghost/core/core/server/data/importer/importers/data/data-importer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,8 @@ DataImporter = {
// Errors preventing import:
if (errors.length > 0) {
debug(errors);
throw errors;
// Rejections should always be with an Error object, not an array
throw errors[0];
}

return {
Expand Down