Skip to content

🎨 Expanded file upload allowlist with non-executable formats #27677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allouis merged 1 commit into from
May 6, 2026
Merged

🎨 Expanded file upload allowlist with non-executable formats #27677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
74 changes: 63 additions & 11 deletions ghost/core/core/shared/config/overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,53 +44,105 @@
},
"files": {
"extensions": [
".pdf",
".json",
".jsonld",
".ods",
".odt",
".pptx",
".rtf",
".txt",
".xls",
".xlsx",
".xml",
".7z",
".aac",
".ai",
".aif",
".aiff",
".apkg",
".arw",
".avif",
".avi",
".blend",
".bmp",
".bz2",
".cr2",
".cr3",
".css",
".csv",
".dng",
".doc",
".docx",
".eot",
".epub",
".eps",
".fb2",
".fbx",
".flac",
".geojson",
".gif",
".glb",
".gltf",
".gpx",
".gz",
".heic",
".heif",
".html",
".ics",
".ipynb",
".jpeg",
".jpg",
".js",
".json",
".jsonld",
".key",
".kml",
".m4a",
".m4v",
".md",
".mid",
".midi",
".mkv",
".mobi",
".mov",
".mp3",
".mp4",
".nef",
".np3",
".numbers",
".obj",
".odp",
".ods",
".odt",
".ogv",
".opus",
".orf",
".otf",
".pages",
".paprikarecipes",
".pdf",
".png",
".ppt",
".pptx",
".psd",
".py",
".raf",
".rar",
".rtf",
".rw2",
".skp",
".stl",
".svg",
".tar",
".tgz",
".tif",
".tiff",
".toml",
".tsv",
".ttf",
".txt",
".vcf",
".wav",
".webm",
".webp",
".woff",
".woff2",
".xcf",
".xls",
".xlsb",
".xlsm",
".xlsx",
".xml",
".yaml",
".zip"
],
Expand Down
4 changes: 2 additions & 2 deletions ghost/core/test/unit/server/data/importer/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ describe('Importer', function () {

it('gets the correct extensions', function () {
assert(Array.isArray(ImportManager.getExtensions()));
assert.equal(ImportManager.getExtensions().length, 55);
assert.equal(ImportManager.getExtensions().length, 105);
assert(ImportManager.getExtensions().includes('.csv'));
assert(ImportManager.getExtensions().includes('.json'));
assert(ImportManager.getExtensions().includes('.zip'));
Expand Down Expand Up @@ -108,7 +108,7 @@ describe('Importer', function () {
});

it('globs extensions correctly', function () {
const extGlob = '+(.jpg|.jpeg|.gif|.png|.svg|.svgz|.ico|.webp|.mp4|.webm|.ogv|.mp3|.wav|.ogg|.m4a|.pdf|.json|.jsonld|.ods|.odt|.pptx|.rtf|.txt|.xls|.xlsx|.xml|.apkg|.css|.csv|.doc|.docx|.epub|.gpx|.html|.ics|.ipynb|.js|.key|.kml|.md|.mobi|.mov|.otf|.pages|.paprikarecipes|.psd|.py|.skp|.woff|.woff2|.xlsb|.xlsm|.yaml|.zip|.markdown)';
const extGlob = '+(.jpg|.jpeg|.gif|.png|.svg|.svgz|.ico|.webp|.mp4|.webm|.ogv|.mp3|.wav|.ogg|.m4a|.7z|.aac|.ai|.aif|.aiff|.apkg|.arw|.avif|.avi|.blend|.bmp|.bz2|.cr2|.cr3|.css|.csv|.dng|.doc|.docx|.eot|.epub|.eps|.fb2|.fbx|.flac|.geojson|.glb|.gltf|.gpx|.gz|.heic|.heif|.html|.ics|.ipynb|.js|.json|.jsonld|.key|.kml|.m4v|.md|.mid|.midi|.mkv|.mobi|.mov|.nef|.np3|.numbers|.obj|.odp|.ods|.odt|.opus|.orf|.otf|.pages|.paprikarecipes|.pdf|.ppt|.pptx|.psd|.py|.raf|.rar|.rtf|.rw2|.skp|.stl|.tar|.tgz|.tif|.tiff|.toml|.tsv|.ttf|.txt|.vcf|.woff|.woff2|.xcf|.xls|.xlsb|.xlsm|.xlsx|.xml|.yaml|.zip|.markdown)';
assert.equal(ImportManager.getGlobPattern(ImportManager.getExtensions()), extGlob);
assert.equal(ImportManager.getGlobPattern(ImportManager.getDirectories()), '+(images|content|media|files)');
assert.equal(ImportManager.getGlobPattern(JSONHandler.extensions), '+(.json)');
Expand Down
Loading