Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change audit log file format into json #349

Merged
merged 33 commits into from
Jan 20, 2024
Merged

change audit log file format into json #349

merged 33 commits into from
Jan 20, 2024

Conversation

SonglinLyu
Copy link
Contributor

change the original binary format of audit log file into readable human json format.

qishipengqsp
qishipengqsp requested changes Jan 8, 2024
View reviewed changes
@qishipengqsp
Copy link
Collaborator

ut不需要修改？

@qishipengqsp qishipengqsp requested a review from ljcui January 8, 2024 15:08
knightast
knightast reviewed Jan 11, 2024
View reviewed changes
@SonglinLyu
Copy link
Contributor Author

ut不需要修改？

原本的ut测试里测了读出来的东西放到lgraph::LogMessage& msg里之后是不是一致的，还需要再加一个比如说验证json文件里的文本内容是否正确的测试吗？

qishipengqsp
qishipengqsp requested changes Jan 15, 2024
View reviewed changes
@qishipengqsp qishipengqsp merged commit f831636 into TuGraph-family:master Jan 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knightast knightast knightast left review comments

@qishipengqsp qishipengqsp qishipengqsp approved these changes

@ljcui ljcui Awaiting requested review from ljcui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SonglinLyu @qishipengqsp @knightast