more mouse controlls #2104
more mouse controlls #2104
Conversation
github-actions
bot
added
the
pr: new extension
There was a problem hiding this comment.
Although it's generally fine syntax-wise, I don't see why or how this can be merged. All of the functionality here is available in native Scratch or through the already existing TurboWarp Blocks extension (e.g., middle mouse button). It would just be a bloat to the gallery
| @@ -0,0 +1,137 @@ | |||
| // Name: More Mouse Controls | |||
| // ID: legobrainbikerMoreMouseControls | |||
| // Description: Some features I felt were missing from the mouse, including right click detection. | |||
There was a problem hiding this comment.
Could you make this description a bit more professional and reminiscent of the extension's qualities?
| document.addEventListener("mousewheel", (e) => { | ||
| this.mouseWheelDelta = e.deltaY; | ||
| Scratch.vm.runtime.startHats( | ||
| "legobrainbikerMoreMouseControls_onScroll" | ||
| ); | ||
| }); |
There was a problem hiding this comment.
On scroll is available in native scratch when doing:
when [up/down arrow] pressed
if <not <up/down arrow pressed>> ?:
scroll action
endif
Because the hat block detects scrolling but the key boolean doesn't, so you can detect scrolling like this.
There was a problem hiding this comment.
I realize this, but I thought this would make it easier, especialy when using the other scroll block. also it works with both at the say time.
There was a problem hiding this comment.
I realize this, but I thought this would make it easier, especialy when using the other scroll block. also it works with both at the say time.
That's a valid point, but it's still probably not worth adding a whole new extension to the gallery though
|
!format |
LegoBrainBiker
changed the title
|
Duplicate of a lot of the other mouse extension pull requests. |
| this.mouseWheelDeltaX = 0; | ||
| this.mouseZoomDelta = 0; | ||
| this.buttons = []; | ||
| document.addEventListener("wheel", (e) => { |
There was a problem hiding this comment.
why cant you just use the built in VM api's for this stuff
| return this.buttonPressed(args); | ||
| } | ||
| buttonPressed({ button }) { | ||
| console.log(button); |
| console.log(this.buttons[Scratch.Cast.toNumber(button)]); | ||
| return this.buttons[Scratch.Cast.toNumber(button)] || false; | ||
| } | ||
| dissableContextMenu() { |
There was a problem hiding this comment.
the way you implement this breaks some addons, and you should allow for reenabling the context menu and scrolling
| console.log(this.buttons[Scratch.Cast.toNumber(button)]); | ||
| return this.buttons[Scratch.Cast.toNumber(button)] || false; | ||
| } | ||
| dissableContextMenu() { |
There was a problem hiding this comment.
you need to check if you already have the event added, otherwise you are just leaking memory..
adds the ability to detect more data from the mouse that would be difficult or imaposible to get otherwise. it's small now, but I'm open to more blocks.