-
Notifications
You must be signed in to change notification settings - Fork 9
Implement Turing-like model
macro
#291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 14760776262Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the Markdown, it's well written. There's a broader conversation about @parameters
that concerns DPPL too, as discussed e.g. today, but I assume that's outside the scope of this PR. I didn't actually read the implementation of the macros.
I added a couple of suggested comments to explain the tests, do edit them if I they are wrong.
Co-authored-by: Markus Hauru <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Benchmark results on macOS (aarch64)BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.6.2 to /Users/runner/.bridgestan/bridgestan-2.6.2 Stan results:
JuliaBUGS Mooncake results:
Benchmark results on Ubuntu (x64)BridgeStan not found at location specified by $BRIDGESTAN environment variable, downloading version 2.6.2 to /home/runner/.bridgestan/bridgestan-2.6.2 Stan results:
JuliaBUGS Mooncake results:
|
@yebai I am merging this. It is not a breaking change because the We can adjust the public interface later, and bump the version then. |
Address #281
Edited:
I wrote some documentation in markdown for this PR and design, there is a slight change from last weeks' Monday meeting.
The markdown doc should be concise enough and I don't think I can make it much shorter without losing essential information.
So could the reviews, please, give https://github.com/TuringLang/JuliaBUGS.jl/blob/sunxd/new_model_syntax/docs/src/julia_syntax.md a quick read?