Skip to content

CompatHelper: bump compat for CairoMakie to 0.13 for package docs, (keep existing compat) #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the CairoMakie package from 0.6 - 0.13.0 to 0.6 - 0.13.0, 0.13 for package docs.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@devmotion devmotion force-pushed the compathelper/new_version/2025-02-10-00-14-03-786-03990792003 branch from 8be60d0 to 62e2775 Compare February 10, 2025 00:14
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.55%. Comparing base (ad4942d) to head (14f07b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #472   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          20       20           
  Lines        1073     1073           
=======================================
  Hits          918      918           
  Misses        155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@penelopeysm
Copy link
Member

Broken by MakieOrg/Makie.jl#4759

@penelopeysm penelopeysm marked this pull request as draft February 10, 2025 23:51
Copy link
Contributor Author

MCMCChains.jl documentation for PR #472 is available at:
https://TuringLang.github.io/MCMCChains.jl/previews/PR472/

@shravanngoswamii shravanngoswamii force-pushed the compathelper/new_version/2025-02-10-00-14-03-786-03990792003 branch from e4a0f3b to 14f07b1 Compare May 23, 2025 09:41
@shravanngoswamii shravanngoswamii marked this pull request as ready for review May 23, 2025 09:42
@shravanngoswamii
Copy link
Member

shravanngoswamii commented May 23, 2025

Broken by MakieOrg/Makie.jl#4759

It's temporarily fixed in v0.13.2 here MakieOrg/Makie.jl#4826 and will be fixed properly in MakieOrg/Makie.jl#4630!

I removed [email protected] from compat entry and docs build succeeds for all versions above and below it, so I suppose we can merge this now!

@shravanngoswamii shravanngoswamii requested a review from yebai May 23, 2025 09:47
@yebai yebai merged commit 268886e into main May 23, 2025
10 checks passed
@yebai yebai deleted the compathelper/new_version/2025-02-10-00-14-03-786-03990792003 branch May 23, 2025 09:58
@yebai
Copy link
Member

yebai commented May 23, 2025

Thanks @penelopeysm @shravanngoswamii!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants